[Libreoffice-commits] core.git: sw/qa

Xisco Fauli (via logerrit) logerrit at kemper.freedesktop.org
Wed Aug 11 07:26:03 UTC 2021


 sw/qa/extras/uiwriter/uiwriter3.cxx |   11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

New commits:
commit 67329f8b75101a78a00bf646bb2c3b9f4575aa5a
Author:     Xisco Fauli <xiscofauli at libreoffice.org>
AuthorDate: Tue Aug 10 19:47:42 2021 +0200
Commit:     Xisco Fauli <xiscofauli at libreoffice.org>
CommitDate: Wed Aug 11 09:25:28 2021 +0200

    tdf#135247: sw_uiwriter3: Add unittest
    
    Change-Id: I4f78b42600c0b7316aee9e6c106a25cc8cff983a
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120285
    Tested-by: Jenkins
    Reviewed-by: Xisco Fauli <xiscofauli at libreoffice.org>

diff --git a/sw/qa/extras/uiwriter/uiwriter3.cxx b/sw/qa/extras/uiwriter/uiwriter3.cxx
index e835acf648cf..c88abacb9536 100644
--- a/sw/qa/extras/uiwriter/uiwriter3.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter3.cxx
@@ -247,11 +247,12 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest3, testTdf132911)
     CPPUNIT_ASSERT_EQUAL(sal_Int32(0), xIndexAccess->getCount());
     CPPUNIT_ASSERT_EQUAL(0, getShapes());
 
-    //FIXME: tdf#135247
-    //dispatchCommand(mxComponent, ".uno:Undo", {});
-    //Scheduler::ProcessEventsToIdle();
-    //CPPUNIT_ASSERT_EQUAL(sal_Int32(1), xIndexAccess->getCount());
-    //CPPUNIT_ASSERT_EQUAL(4, getShapes());
+    //tdf#135247: Without the fix in place, this would have crashed
+    dispatchCommand(mxComponent, ".uno:Undo", {});
+    Scheduler::ProcessEventsToIdle();
+    CPPUNIT_ASSERT_EQUAL(sal_Int32(1), xIndexAccess->getCount());
+    //FIXME: tdf#143815: Number of images should be 4 and not 8
+    CPPUNIT_ASSERT_EQUAL(8, getShapes());
 }
 
 CPPUNIT_TEST_FIXTURE(SwUiWriterTest3, testTdf61154)


More information about the Libreoffice-commits mailing list