[Libreoffice-commits] core.git: svx/source

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Wed Aug 11 07:59:31 UTC 2021


 svx/source/tbxctrls/fillctrl.cxx |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 0c4cdfa9c9ba9548a61c7314858eae01f90f2782
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Tue Aug 10 21:58:27 2021 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Wed Aug 11 09:58:56 2021 +0200

    tdf#143769 don't crash on null XFillColorItem
    
    use same solution as:
    
    commit 5ee0e6ab93ad791f5e79506efafd16cb7364ffb1
    Author: Markus Mohrhard <markus.mohrhard at googlemail.com>
    Date:   Tue Jul 21 19:01:26 2015 +0200
    
        avoid crash with color listbox for now
    
        Change-Id: I36ac6513546961ec8d8d1e9437a8ef88574acbf4
    
    Change-Id: I46c55461e5867431a6e9c838b5ef462f9581eb28
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120297
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/svx/source/tbxctrls/fillctrl.cxx b/svx/source/tbxctrls/fillctrl.cxx
index 282f294f095a..3711d7fc4053 100644
--- a/svx/source/tbxctrls/fillctrl.cxx
+++ b/svx/source/tbxctrls/fillctrl.cxx
@@ -740,10 +740,11 @@ IMPL_LINK_NOARG(SvxFillToolBoxControl, SelectFillTypeHdl, weld::ComboBox&, void)
         {
             mpLbFillAttr->hide();
             mpToolBoxColor->show();
-            const ::Color aColor = mpColorItem->GetColorValue();
-            const XFillColorItem aXFillColorItem( "", aColor );
             if (pSh)
             {
+                const ::Color aColor = mpColorItem ? mpColorItem->GetColorValue() : COL_AUTO;
+                const XFillColorItem aXFillColorItem( "", aColor );
+
                 // #i122676# change FillStyle and Color in one call
                 pSh->GetDispatcher()->ExecuteList(
                     SID_ATTR_FILL_COLOR, SfxCallMode::RECORD,


More information about the Libreoffice-commits mailing list