[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - extensions/uiconfig

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Mon Aug 16 10:09:53 UTC 2021


 extensions/uiconfig/spropctrlr/ui/colorlistbox.ui  |    1 +
 extensions/uiconfig/spropctrlr/ui/datefield.ui     |    1 +
 extensions/uiconfig/spropctrlr/ui/datetimefield.ui |    1 +
 3 files changed, 3 insertions(+)

New commits:
commit 3cb8d55f07ad6bc9d388c8e4feae9841958c6922
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Fri Jul 16 15:44:40 2021 +0100
Commit:     Michael Stahl <michael.stahl at allotropia.de>
CommitDate: Mon Aug 16 12:08:59 2021 +0200

    Related: tdf#143357 explicitly set the default of focus-on-click
    
    this should already be the default according to
    https://developer.gnome.org/gtk3/stable/GtkWidget.html but it's
    apparently False nevertheless, so make it explicit here for these
    widgets where there is a focus watcher to commit their changes and the
    absence of this is non-cosmetic. Just these initially for a small
    backportable change.
    
    Change-Id: I96442b4e844ce0446f56276c1b648ca5ce57b740
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119077
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    (cherry picked from commit a36447215fa13f3ca92b22ac63e8164859ddb8ef)
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120428
    Reviewed-by: Michael Stahl <michael.stahl at allotropia.de>

diff --git a/extensions/uiconfig/spropctrlr/ui/colorlistbox.ui b/extensions/uiconfig/spropctrlr/ui/colorlistbox.ui
index 7361e0d11947..40ae63eac62a 100644
--- a/extensions/uiconfig/spropctrlr/ui/colorlistbox.ui
+++ b/extensions/uiconfig/spropctrlr/ui/colorlistbox.ui
@@ -5,6 +5,7 @@
   <object class="GtkMenuButton" id="colorlistbox">
     <property name="visible">True</property>
     <property name="can_focus">True</property>
+    <property name="focus-on-click">True</property>
     <property name="receives_default">True</property>
     <property name="hexpand">True</property>
     <property name="draw_indicator">True</property>
diff --git a/extensions/uiconfig/spropctrlr/ui/datefield.ui b/extensions/uiconfig/spropctrlr/ui/datefield.ui
index 6ca77af072ee..e064f618bfd5 100644
--- a/extensions/uiconfig/spropctrlr/ui/datefield.ui
+++ b/extensions/uiconfig/spropctrlr/ui/datefield.ui
@@ -5,6 +5,7 @@
   <object class="GtkMenuButton" id="datefield">
     <property name="visible">True</property>
     <property name="can_focus">True</property>
+    <property name="focus-on-click">True</property>
     <property name="receives_default">False</property>
     <property name="hexpand">True</property>
     <property name="draw_indicator">True</property>
diff --git a/extensions/uiconfig/spropctrlr/ui/datetimefield.ui b/extensions/uiconfig/spropctrlr/ui/datetimefield.ui
index aed958450b1e..f736a8e63221 100644
--- a/extensions/uiconfig/spropctrlr/ui/datetimefield.ui
+++ b/extensions/uiconfig/spropctrlr/ui/datetimefield.ui
@@ -16,6 +16,7 @@
       <object class="GtkMenuButton" id="datefield">
         <property name="visible">True</property>
         <property name="can_focus">True</property>
+        <property name="focus-on-click">True</property>
         <property name="receives_default">False</property>
         <property name="hexpand">True</property>
         <property name="draw_indicator">True</property>


More information about the Libreoffice-commits mailing list