[Libreoffice-commits] core.git: sc/qa

[Radhey Parekh (via logerrit)]

 sc/qa/extras/macros-test.cxx            |    1 -
 sc/qa/extras/scstylefamiliesobj.cxx     |    2 --
 sc/qa/extras/scuniquecellformatsobj.cxx |    1 -
 sc/qa/perf/scperfobj.cxx                |    2 --
 4 files changed, 6 deletions(-)

New commits:
commit b3f3f0cb2a5ea7873349f733b55e41c1cbc671dc
Author:     Radhey Parekh <radhey.parekh at gmail.com>
AuthorDate: Tue Aug 24 22:13:40 2021 +0530
Commit:     Ilmari Lauhakangas <ilmari.lauhakangas at libreoffice.org>
CommitDate: Thu Aug 26 16:06:08 2021 +0200

    tdf#139734 Drop redundant asserts after MacrosTest::loadFromDesktop
    
    Change-Id: I8ccb5e43ac86ff2b8da94bd03e6fa50de0c33741
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120961
    Tested-by: Jenkins
    Reviewed-by: Hossein <hossein at libreoffice.org>
    Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas at libreoffice.org>

diff --git a/sc/qa/extras/macros-test.cxx b/sc/qa/extras/macros-test.cxx
index f7b33dd04768..885c7d351f6e 100644
--- a/sc/qa/extras/macros-test.cxx
+++ b/sc/qa/extras/macros-test.cxx
@@ -1096,7 +1096,6 @@ void ScMacrosTest::testTdf90278()
     OUString aFileName;
     createFileURL(u"tdf90278.xls", aFileName);
     auto xComponent = loadFromDesktop(aFileName, "com.sun.star.sheet.SpreadsheetDocument");
-    CPPUNIT_ASSERT(xComponent);
 
     SfxObjectShell* pFoundShell = SfxObjectShell::GetShellFromComponent(xComponent);
     CPPUNIT_ASSERT(pFoundShell);
diff --git a/sc/qa/extras/scstylefamiliesobj.cxx b/sc/qa/extras/scstylefamiliesobj.cxx
index 5a7197736965..9b789d9357b6 100644
--- a/sc/qa/extras/scstylefamiliesobj.cxx
+++ b/sc/qa/extras/scstylefamiliesobj.cxx
@@ -125,10 +125,8 @@ void ScStyleFamiliesObj::setUp()
     CalcUnoApiTest::setUp();
     // create a calc document
     m_xComponent = loadFromDesktop("private:factory/scalc");
-    CPPUNIT_ASSERT_MESSAGE("no component", m_xComponent.is());
 
     m_xSrcComponent = loadFromDesktop(getTestURL());
-    CPPUNIT_ASSERT_MESSAGE("no src component", m_xSrcComponent.is());
 }
 
 void ScStyleFamiliesObj::tearDown()
diff --git a/sc/qa/extras/scuniquecellformatsobj.cxx b/sc/qa/extras/scuniquecellformatsobj.cxx
index 6921ec55c131..e3050200e72f 100644
--- a/sc/qa/extras/scuniquecellformatsobj.cxx
+++ b/sc/qa/extras/scuniquecellformatsobj.cxx
@@ -85,7 +85,6 @@ void ScUniqueCellFormatsObj::setUp()
 {
     CalcUnoApiTest::setUp();
     m_xComponent = loadFromDesktop("private:factory/scalc");
-    CPPUNIT_ASSERT_MESSAGE("no component", m_xComponent.is());
 }
 
 void ScUniqueCellFormatsObj::tearDown()
diff --git a/sc/qa/perf/scperfobj.cxx b/sc/qa/perf/scperfobj.cxx
index fb7854bd88be..7b9ed7927098 100644
--- a/sc/qa/perf/scperfobj.cxx
+++ b/sc/qa/perf/scperfobj.cxx
@@ -114,8 +114,6 @@ uno::Reference< uno::XInterface > ScPerfObj::init(const OUString& aFileName)
 
     mxComponent = loadFromDesktop(aFileURL);
 
-    CPPUNIT_ASSERT(mxComponent.is());
-
     return mxComponent;
 }