[Libreoffice-commits] core.git: chart2/source
Noel Grandin (via logerrit)
logerrit at kemper.freedesktop.org
Tue Aug 31 12:30:23 UTC 2021
chart2/source/controller/chartapiwrapper/ChartDataWrapper.cxx | 27 +++-------
chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx | 2
chart2/source/controller/chartapiwrapper/DiagramWrapper.cxx | 6 --
chart2/source/controller/chartapiwrapper/WrappedStockProperties.cxx | 1
chart2/source/controller/dialogs/ChartResourceGroups.cxx | 15 +----
chart2/source/controller/dialogs/ChartTypeDialogController.cxx | 1
chart2/source/controller/dialogs/TimerTriggeredControllerLock.cxx | 2
chart2/source/controller/dialogs/dlg_ObjectProperties.cxx | 2
chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx | 1
chart2/source/controller/dialogs/tp_AxisPositions.cxx | 1
chart2/source/controller/dialogs/tp_RangeChooser.cxx | 1
chart2/source/controller/itemsetwrapper/DataPointItemConverter.cxx | 1
chart2/source/controller/itemsetwrapper/SeriesOptionsItemConverter.cxx | 1
chart2/source/controller/main/ChartController.cxx | 6 --
chart2/source/controller/main/DragMethod_RotateDiagram.cxx | 1
chart2/source/controller/main/UndoGuard.cxx | 1
chart2/source/controller/sidebar/ChartElementsPanel.cxx | 1
chart2/source/controller/sidebar/ChartTypePanel.cxx | 1
chart2/source/model/main/Axis.cxx | 4 -
chart2/source/model/main/FormattedString.cxx | 2
chart2/source/model/main/UndoManager.cxx | 1
chart2/source/model/template/BubbleDataInterpreter.cxx | 3 -
chart2/source/model/template/ColumnLineDataInterpreter.cxx | 1
chart2/source/model/template/StockDataInterpreter.cxx | 1
chart2/source/model/template/XYDataInterpreter.cxx | 3 -
chart2/source/tools/CachedDataSequence.cxx | 4 -
chart2/source/tools/ExplicitCategoriesProvider.cxx | 1
chart2/source/tools/LinearRegressionCurveCalculator.cxx | 3 -
chart2/source/tools/NameContainer.cxx | 1
chart2/source/tools/ObjectIdentifier.cxx | 5 -
chart2/source/tools/UncachedDataSequence.cxx | 4 -
chart2/source/view/axes/ScaleAutomatism.cxx | 2
chart2/source/view/axes/VAxisProperties.cxx | 3 -
chart2/source/view/axes/VCoordinateSystem.cxx | 2
chart2/source/view/axes/VPolarAxis.cxx | 1
chart2/source/view/axes/VPolarGrid.cxx | 1
chart2/source/view/charttypes/PieChart.cxx | 2
chart2/source/view/charttypes/VSeriesPlotter.cxx | 3 -
chart2/source/view/diagram/VDiagram.cxx | 1
chart2/source/view/main/ChartView.cxx | 6 --
chart2/source/view/main/PlotterBase.cxx | 1
chart2/source/view/main/PlottingPositionHelper.cxx | 5 -
chart2/source/view/main/VDataSeries.cxx | 7 --
chart2/source/view/main/VTitle.cxx | 1
44 files changed, 25 insertions(+), 114 deletions(-)
New commits:
commit 6191fc447395e877876290eedf28019a1866958d
Author: Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Tue Aug 31 10:46:25 2021 +0200
Commit: Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Tue Aug 31 14:29:44 2021 +0200
clang-tidy:readability-redundant-member-init
Change-Id: I5e8baec88d5f17ddda452bd945c87769623cb4e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121357
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
diff --git a/chart2/source/controller/chartapiwrapper/ChartDataWrapper.cxx b/chart2/source/controller/chartapiwrapper/ChartDataWrapper.cxx
index aabdce1c8f65..76df74719682 100644
--- a/chart2/source/controller/chartapiwrapper/ChartDataWrapper.cxx
+++ b/chart2/source/controller/chartapiwrapper/ChartDataWrapper.cxx
@@ -110,8 +110,7 @@ namespace {
struct lcl_AllOperator : public lcl_Operator
{
explicit lcl_AllOperator( const Reference< XChartData >& xDataToApply )
- : lcl_Operator()
- , m_xDataToApply( xDataToApply )
+ : m_xDataToApply( xDataToApply )
{
}
@@ -157,8 +156,7 @@ struct lcl_AllOperator : public lcl_Operator
struct lcl_DataOperator : public lcl_Operator
{
explicit lcl_DataOperator( const Sequence< Sequence< double > >& rData )
- : lcl_Operator()
- , m_rData( rData )
+ : m_rData( rData )
{
}
@@ -175,8 +173,7 @@ struct lcl_RowDescriptionsOperator : public lcl_Operator
{
lcl_RowDescriptionsOperator( const Sequence< OUString >& rRowDescriptions
, const Reference< chart2::XChartDocument >& xChartDoc )
- : lcl_Operator()
- , m_rRowDescriptions( rRowDescriptions )
+ : m_rRowDescriptions( rRowDescriptions )
, m_xChartDoc(xChartDoc)
, m_bDataInColumns(true)
{
@@ -207,8 +204,7 @@ struct lcl_ComplexRowDescriptionsOperator : public lcl_Operator
{
lcl_ComplexRowDescriptionsOperator( const Sequence< Sequence< OUString > >& rComplexRowDescriptions
, const Reference< chart2::XChartDocument >& xChartDoc )
- : lcl_Operator()
- , m_rComplexRowDescriptions( rComplexRowDescriptions )
+ : m_rComplexRowDescriptions( rComplexRowDescriptions )
, m_xChartDoc(xChartDoc)
, m_bDataInColumns(true)
{
@@ -238,8 +234,7 @@ struct lcl_ComplexRowDescriptionsOperator : public lcl_Operator
struct lcl_AnyRowDescriptionsOperator : public lcl_Operator
{
explicit lcl_AnyRowDescriptionsOperator( const Sequence< Sequence< uno::Any > >& rAnyRowDescriptions )
- : lcl_Operator()
- , m_rAnyRowDescriptions( rAnyRowDescriptions )
+ : m_rAnyRowDescriptions( rAnyRowDescriptions )
{
}
@@ -261,8 +256,7 @@ struct lcl_ColumnDescriptionsOperator : public lcl_Operator
{
lcl_ColumnDescriptionsOperator( const Sequence< OUString >& rColumnDescriptions
, const Reference< chart2::XChartDocument >& xChartDoc )
- : lcl_Operator()
- , m_rColumnDescriptions( rColumnDescriptions )
+ : m_rColumnDescriptions( rColumnDescriptions )
, m_xChartDoc(xChartDoc)
, m_bDataInColumns(true)
{
@@ -293,8 +287,7 @@ struct lcl_ComplexColumnDescriptionsOperator : public lcl_Operator
{
lcl_ComplexColumnDescriptionsOperator( const Sequence< Sequence< OUString > >& rComplexColumnDescriptions
, const Reference< chart2::XChartDocument >& xChartDoc )
- : lcl_Operator()
- , m_rComplexColumnDescriptions( rComplexColumnDescriptions )
+ : m_rComplexColumnDescriptions( rComplexColumnDescriptions )
, m_xChartDoc(xChartDoc)
, m_bDataInColumns(true)
{
@@ -324,8 +317,7 @@ struct lcl_ComplexColumnDescriptionsOperator : public lcl_Operator
struct lcl_AnyColumnDescriptionsOperator : public lcl_Operator
{
explicit lcl_AnyColumnDescriptionsOperator( const Sequence< Sequence< uno::Any > >& rAnyColumnDescriptions )
- : lcl_Operator()
- , m_rAnyColumnDescriptions( rAnyColumnDescriptions )
+ : m_rAnyColumnDescriptions( rAnyColumnDescriptions )
{
}
@@ -346,8 +338,7 @@ struct lcl_AnyColumnDescriptionsOperator : public lcl_Operator
struct lcl_DateCategoriesOperator : public lcl_Operator
{
explicit lcl_DateCategoriesOperator( const Sequence< double >& rDates )
- : lcl_Operator()
- , m_rDates( rDates )
+ : m_rDates( rDates )
{
}
diff --git a/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx b/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx
index cf087c863d98..898e4676c763 100644
--- a/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx
+++ b/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx
@@ -270,7 +270,6 @@ private: //member
WrappedDataSourceLabelsInFirstRowProperty::WrappedDataSourceLabelsInFirstRowProperty(const std::shared_ptr<Chart2ModelContact>& spChart2ModelContact)
: WrappedProperty("DataSourceLabelsInFirstRow",OUString())
, m_spChart2ModelContact( spChart2ModelContact )
- , m_aOuterValue()
{
m_aOuterValue = WrappedDataSourceLabelsInFirstRowProperty::getPropertyDefault( nullptr );
}
@@ -361,7 +360,6 @@ private: //member
WrappedDataSourceLabelsInFirstColumnProperty::WrappedDataSourceLabelsInFirstColumnProperty(const std::shared_ptr<Chart2ModelContact>& spChart2ModelContact)
: WrappedProperty("DataSourceLabelsInFirstColumn",OUString())
, m_spChart2ModelContact( spChart2ModelContact )
- , m_aOuterValue()
{
m_aOuterValue = WrappedDataSourceLabelsInFirstColumnProperty::getPropertyDefault( nullptr );
}
diff --git a/chart2/source/controller/chartapiwrapper/DiagramWrapper.cxx b/chart2/source/controller/chartapiwrapper/DiagramWrapper.cxx
index 8b068a9a57c7..a55733ffffd8 100644
--- a/chart2/source/controller/chartapiwrapper/DiagramWrapper.cxx
+++ b/chart2/source/controller/chartapiwrapper/DiagramWrapper.cxx
@@ -1118,7 +1118,6 @@ private: //member
WrappedDataRowSourceProperty::WrappedDataRowSourceProperty(const std::shared_ptr<Chart2ModelContact>& spChart2ModelContact)
: WrappedProperty("DataRowSource",OUString())
, m_spChart2ModelContact( spChart2ModelContact )
- , m_aOuterValue()
{
m_aOuterValue = WrappedDataRowSourceProperty::getPropertyDefault( nullptr );
}
@@ -1217,7 +1216,6 @@ WrappedStackingProperty::WrappedStackingProperty(StackMode eStackMode, const std
: WrappedProperty(OUString(),OUString())
, m_spChart2ModelContact( spChart2ModelContact )
, m_eStackMode( eStackMode )
- , m_aOuterValue()
{
switch( m_eStackMode )
{
@@ -1315,7 +1313,6 @@ private: //member
WrappedDim3DProperty::WrappedDim3DProperty(const std::shared_ptr<Chart2ModelContact>& spChart2ModelContact)
: WrappedProperty("Dim3D",OUString())
, m_spChart2ModelContact( spChart2ModelContact )
- , m_aOuterValue()
{
m_aOuterValue = WrappedDim3DProperty::getPropertyDefault( nullptr );
}
@@ -1379,7 +1376,6 @@ private: //member
WrappedVerticalProperty::WrappedVerticalProperty(const std::shared_ptr<Chart2ModelContact>& spChart2ModelContact)
: WrappedProperty("Vertical",OUString())
, m_spChart2ModelContact( spChart2ModelContact )
- , m_aOuterValue()
{
m_aOuterValue = WrappedVerticalProperty::getPropertyDefault( nullptr );
}
@@ -1595,7 +1591,6 @@ private: //member
WrappedAttributedDataPointsProperty::WrappedAttributedDataPointsProperty(const std::shared_ptr<Chart2ModelContact>& spChart2ModelContact)
: WrappedProperty("AttributedDataPoints",OUString())
, m_spChart2ModelContact( spChart2ModelContact )
- , m_aOuterValue()
{
m_aOuterValue = WrappedAttributedDataPointsProperty::getPropertyDefault( nullptr );
}
@@ -1700,7 +1695,6 @@ private: //member
WrappedSolidTypeProperty::WrappedSolidTypeProperty(const std::shared_ptr<Chart2ModelContact>& spChart2ModelContact)
: WrappedProperty( "SolidType", OUString() )
, m_spChart2ModelContact( spChart2ModelContact )
- , m_aOuterValue()
{
m_aOuterValue = WrappedSolidTypeProperty::getPropertyDefault( nullptr );
}
diff --git a/chart2/source/controller/chartapiwrapper/WrappedStockProperties.cxx b/chart2/source/controller/chartapiwrapper/WrappedStockProperties.cxx
index 5e7a2808f832..54027301f53b 100644
--- a/chart2/source/controller/chartapiwrapper/WrappedStockProperties.cxx
+++ b/chart2/source/controller/chartapiwrapper/WrappedStockProperties.cxx
@@ -63,7 +63,6 @@ WrappedStockProperty::WrappedStockProperty( const OUString& rOuterName
, const std::shared_ptr<Chart2ModelContact>& spChart2ModelContact )
: WrappedProperty(rOuterName,OUString())
, m_spChart2ModelContact(spChart2ModelContact)
- , m_aOuterValue()
, m_aDefaultValue(rDefaulValue)
{
}
diff --git a/chart2/source/controller/dialogs/ChartResourceGroups.cxx b/chart2/source/controller/dialogs/ChartResourceGroups.cxx
index bc1ccc81e7c9..19534aa1e0b0 100644
--- a/chart2/source/controller/dialogs/ChartResourceGroups.cxx
+++ b/chart2/source/controller/dialogs/ChartResourceGroups.cxx
@@ -29,8 +29,7 @@ using namespace ::com::sun::star;
using namespace ::com::sun::star::chart2;
Dim3DLookResourceGroup::Dim3DLookResourceGroup(weld::Builder* pBuilder)
- : ChangingResource()
- , m_xCB_3DLook(pBuilder->weld_check_button("3dlook"))
+ : m_xCB_3DLook(pBuilder->weld_check_button("3dlook"))
, m_xLB_Scheme(pBuilder->weld_combo_box("3dscheme"))
{
m_xCB_3DLook->connect_toggled(LINK(this, Dim3DLookResourceGroup, Dim3DLookCheckHdl));
@@ -88,8 +87,7 @@ IMPL_LINK_NOARG(Dim3DLookResourceGroup, SelectSchemeHdl, weld::ComboBox&, void)
}
SortByXValuesResourceGroup::SortByXValuesResourceGroup(weld::Builder* pBuilder)
- : ChangingResource()
- , m_xCB_XValueSorting(pBuilder->weld_check_button("sort"))
+ : m_xCB_XValueSorting(pBuilder->weld_check_button("sort"))
{
m_xCB_XValueSorting->connect_toggled(
LINK(this, SortByXValuesResourceGroup, SortByXValuesCheckHdl));
@@ -117,8 +115,7 @@ IMPL_LINK_NOARG(SortByXValuesResourceGroup, SortByXValuesCheckHdl, weld::Togglea
}
StackingResourceGroup::StackingResourceGroup(weld::Builder* pBuilder)
- : ChangingResource()
- , m_xCB_Stacked(pBuilder->weld_check_button("stack"))
+ : m_xCB_Stacked(pBuilder->weld_check_button("stack"))
, m_xRB_Stack_Y(pBuilder->weld_radio_button("ontop"))
, m_xRB_Stack_Y_Percent(pBuilder->weld_radio_button("percent"))
, m_xRB_Stack_Z(pBuilder->weld_radio_button("deep"))
@@ -200,8 +197,7 @@ IMPL_LINK_NOARG(StackingResourceGroup, StackingEnableHdl, weld::Toggleable&, voi
}
SplineResourceGroup::SplineResourceGroup(weld::Builder* pBuilder, weld::Window* pParent)
- : ChangingResource()
- , m_pParent(pParent)
+ : m_pParent(pParent)
, m_xFT_LineType(pBuilder->weld_label("linetypeft"))
, m_xLB_LineType(pBuilder->weld_combo_box("linetype"))
, m_xPB_DetailsDialog(pBuilder->weld_button("properties"))
@@ -332,8 +328,7 @@ IMPL_LINK_NOARG(SplineResourceGroup, SteppedDetailsDialogHdl, weld::Button&, voi
}
GeometryResourceGroup::GeometryResourceGroup(weld::Builder* pBuilder)
- : ChangingResource()
- , m_aGeometryResources(pBuilder)
+ : m_aGeometryResources(pBuilder)
{
m_aGeometryResources.connect_changed(LINK(this, GeometryResourceGroup, GeometryChangeHdl));
}
diff --git a/chart2/source/controller/dialogs/ChartTypeDialogController.cxx b/chart2/source/controller/dialogs/ChartTypeDialogController.cxx
index b0fda08c72f6..7286bccdc32f 100644
--- a/chart2/source/controller/dialogs/ChartTypeDialogController.cxx
+++ b/chart2/source/controller/dialogs/ChartTypeDialogController.cxx
@@ -367,7 +367,6 @@ void ChartTypeDialogController::setTemplateProperties( const uno::Reference< bea
}
ColumnOrBarChartDialogController_Base::ColumnOrBarChartDialogController_Base()
- : ChartTypeDialogController()
{
}
ColumnOrBarChartDialogController_Base::~ColumnOrBarChartDialogController_Base()
diff --git a/chart2/source/controller/dialogs/TimerTriggeredControllerLock.cxx b/chart2/source/controller/dialogs/TimerTriggeredControllerLock.cxx
index 1215e7b40cdf..f64fc6fa11ff 100644
--- a/chart2/source/controller/dialogs/TimerTriggeredControllerLock.cxx
+++ b/chart2/source/controller/dialogs/TimerTriggeredControllerLock.cxx
@@ -28,8 +28,6 @@ using namespace ::com::sun::star;
TimerTriggeredControllerLock::TimerTriggeredControllerLock(
const uno::Reference<frame::XModel>& xModel)
: m_xModel(xModel)
- , m_apControllerLockGuard()
- , m_aTimer()
{
m_aTimer.SetTimeout(4 * EDIT_UPDATEDATA_TIMEOUT);
m_aTimer.SetInvokeHandler(LINK(this, TimerTriggeredControllerLock, TimerTimeout));
diff --git a/chart2/source/controller/dialogs/dlg_ObjectProperties.cxx b/chart2/source/controller/dialogs/dlg_ObjectProperties.cxx
index a6e2c38c6aa1..56e9c4611f24 100644
--- a/chart2/source/controller/dialogs/dlg_ObjectProperties.cxx
+++ b/chart2/source/controller/dialogs/dlg_ObjectProperties.cxx
@@ -82,7 +82,6 @@ ObjectPropertiesDialogParameter::ObjectPropertiesDialogParameter( const OUString
: m_aObjectCID( rObjectCID )
, m_eObjectType( ObjectIdentifier::getObjectType( m_aObjectCID ) )
, m_bAffectsMultipleObjects(false)
- , m_aLocalizedName()
, m_bHasGeometryProperties(false)
, m_bHasStatisticProperties(false)
, m_bProvidesSecondaryYAxis(false)
@@ -100,7 +99,6 @@ ObjectPropertiesDialogParameter::ObjectPropertiesDialogParameter( const OUString
, m_bShowAxisOrigin(false)
, m_bIsCrossingAxisIsCategoryAxis(false)
, m_bSupportingCategoryPositioning(false)
- , m_aCategories()
, m_bComplexCategoriesAxis( false )
, m_nNbPoints( 0 )
{
diff --git a/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx b/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx
index c4b28162d08c..878f3fa0b204 100644
--- a/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx
+++ b/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx
@@ -67,7 +67,6 @@ struct LightSourceInfo
LightSourceInfo::LightSourceInfo()
: pButton(nullptr)
- , aLightSource()
{
aLightSource.nDiffuseColor = Color(0xffffff); // white
aLightSource.aDirection = drawing::Direction3D(1,1,1);
diff --git a/chart2/source/controller/dialogs/tp_AxisPositions.cxx b/chart2/source/controller/dialogs/tp_AxisPositions.cxx
index d4e7fa218023..6812e9f94818 100644
--- a/chart2/source/controller/dialogs/tp_AxisPositions.cxx
+++ b/chart2/source/controller/dialogs/tp_AxisPositions.cxx
@@ -36,7 +36,6 @@ AxisPositionsTabPage::AxisPositionsTabPage(weld::Container* pPage, weld::DialogC
: SfxTabPage(pPage, pController, "modules/schart/ui/tp_AxisPositions.ui", "tp_AxisPositions", &rInAttrs)
, m_pNumFormatter(nullptr)
, m_bCrossingAxisIsCategoryAxis(false)
- , m_aCategories()
, m_bSupportAxisPositioning(false)
, m_bSupportCategoryPositioning(false)
, m_xFL_AxisLine(m_xBuilder->weld_frame("FL_AXIS_LINE"))
diff --git a/chart2/source/controller/dialogs/tp_RangeChooser.cxx b/chart2/source/controller/dialogs/tp_RangeChooser.cxx
index e0ceccec2fe0..6ef5d45ddd40 100644
--- a/chart2/source/controller/dialogs/tp_RangeChooser.cxx
+++ b/chart2/source/controller/dialogs/tp_RangeChooser.cxx
@@ -64,7 +64,6 @@ RangeChooserTabPage::RangeChooserTabPage(weld::Container* pPage, weld::DialogCon
: OWizardPage(pPage, pController, "modules/schart/ui/tp_RangeChooser.ui", "tp_RangeChooser")
, m_nChangingControlCalls(0)
, m_bIsDirty(false)
- , m_aLastValidRangeString()
, m_pTemplateProvider(pTemplateProvider)
, m_rDialogModel( rDialogModel )
, m_pTabPageNotifiable(dynamic_cast<TabPageNotifiable*>(pController))
diff --git a/chart2/source/controller/itemsetwrapper/DataPointItemConverter.cxx b/chart2/source/controller/itemsetwrapper/DataPointItemConverter.cxx
index 51dfcf3e7dc0..fccdee2ac33e 100644
--- a/chart2/source/controller/itemsetwrapper/DataPointItemConverter.cxx
+++ b/chart2/source/controller/itemsetwrapper/DataPointItemConverter.cxx
@@ -219,7 +219,6 @@ DataPointItemConverter::DataPointItemConverter(
m_nSpecialFillColor(ColorTransparency, nSpecialFillColor),
m_nNumberFormat(nNumberFormat),
m_nPercentNumberFormat(nPercentNumberFormat),
- m_aAvailableLabelPlacements(),
m_bForbidPercentValue(true),
m_bHideLegendEntry(false),
m_nPointIndex(nPointIndex),
diff --git a/chart2/source/controller/itemsetwrapper/SeriesOptionsItemConverter.cxx b/chart2/source/controller/itemsetwrapper/SeriesOptionsItemConverter.cxx
index 60f225db577f..adaa328e636d 100644
--- a/chart2/source/controller/itemsetwrapper/SeriesOptionsItemConverter.cxx
+++ b/chart2/source/controller/itemsetwrapper/SeriesOptionsItemConverter.cxx
@@ -60,7 +60,6 @@ SeriesOptionsItemConverter::SeriesOptionsItemConverter(
, m_bSupportingStartingAngle(false)
, m_nStartingAngle(90)
, m_bClockwise(false)
- , m_aSupportedMissingValueTreatments()
, m_nMissingValueTreatment(0)
, m_bSupportingPlottingOfHiddenCells(false)
, m_bIncludeHiddenCells(true)
diff --git a/chart2/source/controller/main/ChartController.cxx b/chart2/source/controller/main/ChartController.cxx
index 5adc15f78a09..8f6b0644e6e3 100644
--- a/chart2/source/controller/main/ChartController.cxx
+++ b/chart2/source/controller/main/ChartController.cxx
@@ -99,12 +99,8 @@ using ::com::sun::star::uno::Sequence;
ChartController::ChartController(uno::Reference<uno::XComponentContext> const & xContext) :
m_aLifeTimeManager( nullptr ),
m_bSuspended( false ),
- m_xCC(xContext), //@todo is it allowed to hold this context??
- m_aModelMutex(),
+ m_xCC(xContext),
m_aModel( nullptr, m_aModelMutex ),
- m_xViewWindow(),
- m_xChartView(),
- m_pDrawModelWrapper(),
m_eDragMode(SdrDragMode::Move),
m_bWaitingForDoubleClick(false),
m_bWaitingForMouseUp(false),
diff --git a/chart2/source/controller/main/DragMethod_RotateDiagram.cxx b/chart2/source/controller/main/DragMethod_RotateDiagram.cxx
index 7501f0bf7204..7a9dbe91a476 100644
--- a/chart2/source/controller/main/DragMethod_RotateDiagram.cxx
+++ b/chart2/source/controller/main/DragMethod_RotateDiagram.cxx
@@ -50,7 +50,6 @@ DragMethod_RotateDiagram::DragMethod_RotateDiagram( DrawViewWrapper& rDrawViewWr
, m_pScene(nullptr)
, m_aReferenceRect(100,100,100,100)
, m_aStartPos(0,0)
- , m_aWireframePolyPolygon()
, m_fInitialXAngleRad(0.0)
, m_fInitialYAngleRad(0.0)
, m_fInitialZAngleRad(0.0)
diff --git a/chart2/source/controller/main/UndoGuard.cxx b/chart2/source/controller/main/UndoGuard.cxx
index 91687aebd28f..e10d9216137d 100644
--- a/chart2/source/controller/main/UndoGuard.cxx
+++ b/chart2/source/controller/main/UndoGuard.cxx
@@ -37,7 +37,6 @@ UndoGuard::UndoGuard( const OUString& i_undoString, const uno::Reference< docume
const ModelFacet i_facet )
:m_xChartModel( i_undoManager->getParent(), uno::UNO_QUERY_THROW )
,m_xUndoManager( i_undoManager )
- ,m_pDocumentSnapshot()
,m_aUndoString( i_undoString )
,m_bActionPosted( false )
{
diff --git a/chart2/source/controller/sidebar/ChartElementsPanel.cxx b/chart2/source/controller/sidebar/ChartElementsPanel.cxx
index 7bf6663243f7..e24cde11ffb1 100644
--- a/chart2/source/controller/sidebar/ChartElementsPanel.cxx
+++ b/chart2/source/controller/sidebar/ChartElementsPanel.cxx
@@ -326,7 +326,6 @@ ChartElementsPanel::ChartElementsPanel(
, mxLBGrid(m_xBuilder->weld_label("label_gri"))
, mxLBLegendPosition(m_xBuilder->weld_combo_box("comboboxtext_legend"))
, mxBoxLegend(m_xBuilder->weld_widget("box_legend"))
- , maContext()
, mxModel(pController->getModel())
, mxListener(new ChartSidebarModifyListener(this))
, mbModelValid(true)
diff --git a/chart2/source/controller/sidebar/ChartTypePanel.cxx b/chart2/source/controller/sidebar/ChartTypePanel.cxx
index 2fca2443807f..a05990a37f20 100644
--- a/chart2/source/controller/sidebar/ChartTypePanel.cxx
+++ b/chart2/source/controller/sidebar/ChartTypePanel.cxx
@@ -41,7 +41,6 @@ namespace chart::sidebar
{
ChartTypePanel::ChartTypePanel(weld::Widget* pParent, ::chart::ChartController* pController)
: PanelLayout(pParent, "ChartTypePanel", "modules/schart/ui/sidebartype.ui")
- , maContext()
, mxModel(pController->getModel())
, mxListener(new ChartSidebarModifyListener(this))
, mbModelValid(true)
diff --git a/chart2/source/model/main/Axis.cxx b/chart2/source/model/main/Axis.cxx
index d736ca6c5137..332ed7a5e5f7 100644
--- a/chart2/source/model/main/Axis.cxx
+++ b/chart2/source/model/main/Axis.cxx
@@ -325,9 +325,7 @@ Axis::Axis() :
::property::OPropertySet( m_aMutex ),
m_xModifyEventForwarder( ModifyListenerHelper::createModifyEventForwarder()),
m_aScaleData( AxisHelper::createDefaultScale() ),
- m_xGrid( new GridProperties() ),
- m_aSubGridProperties(),
- m_xTitle()
+ m_xGrid( new GridProperties() )
{
osl_atomic_increment(&m_refCount);
setFastPropertyValue_NoBroadcast(
diff --git a/chart2/source/model/main/FormattedString.cxx b/chart2/source/model/main/FormattedString.cxx
index 0d6e733a2c31..5433f3683d78 100644
--- a/chart2/source/model/main/FormattedString.cxx
+++ b/chart2/source/model/main/FormattedString.cxx
@@ -97,9 +97,7 @@ namespace chart
FormattedString::FormattedString() :
::property::OPropertySet( m_aMutex ),
- m_aString(),
m_aType(chart2::DataPointCustomLabelFieldType::DataPointCustomLabelFieldType_TEXT),
- m_aGuid(),
m_xModifyEventForwarder( ModifyListenerHelper::createModifyEventForwarder())
{}
diff --git a/chart2/source/model/main/UndoManager.cxx b/chart2/source/model/main/UndoManager.cxx
index 1201d9875bbf..63dacf48444c 100644
--- a/chart2/source/model/main/UndoManager.cxx
+++ b/chart2/source/model/main/UndoManager.cxx
@@ -54,7 +54,6 @@ namespace chart
,m_rParent( i_parent )
,m_rMutex( i_mutex )
,m_bDisposed( false )
- ,m_aUndoManager()
,m_aUndoHelper( *this )
{
m_aUndoManager.SetMaxUndoActionCount(
diff --git a/chart2/source/model/template/BubbleDataInterpreter.cxx b/chart2/source/model/template/BubbleDataInterpreter.cxx
index 3078d3590a42..83868db778e5 100644
--- a/chart2/source/model/template/BubbleDataInterpreter.cxx
+++ b/chart2/source/model/template/BubbleDataInterpreter.cxx
@@ -35,8 +35,7 @@ using ::com::sun::star::uno::Sequence;
namespace chart
{
-BubbleDataInterpreter::BubbleDataInterpreter() :
- DataInterpreter()
+BubbleDataInterpreter::BubbleDataInterpreter()
{
}
diff --git a/chart2/source/model/template/ColumnLineDataInterpreter.cxx b/chart2/source/model/template/ColumnLineDataInterpreter.cxx
index b99324d27c00..f59c98c489b6 100644
--- a/chart2/source/model/template/ColumnLineDataInterpreter.cxx
+++ b/chart2/source/model/template/ColumnLineDataInterpreter.cxx
@@ -35,7 +35,6 @@ namespace chart
// explicit
ColumnLineDataInterpreter::ColumnLineDataInterpreter(
sal_Int32 nNumberOfLines ) :
- DataInterpreter(),
m_nNumberOfLines( nNumberOfLines )
{}
diff --git a/chart2/source/model/template/StockDataInterpreter.cxx b/chart2/source/model/template/StockDataInterpreter.cxx
index dd42201c31c6..95018fad52ac 100644
--- a/chart2/source/model/template/StockDataInterpreter.cxx
+++ b/chart2/source/model/template/StockDataInterpreter.cxx
@@ -36,7 +36,6 @@ namespace chart
// explicit
StockDataInterpreter::StockDataInterpreter(
StockChartTypeTemplate::StockVariant eVariant ) :
- DataInterpreter(),
m_eStockVariant( eVariant )
{}
diff --git a/chart2/source/model/template/XYDataInterpreter.cxx b/chart2/source/model/template/XYDataInterpreter.cxx
index a3fb67fa9202..17e9f57cfc92 100644
--- a/chart2/source/model/template/XYDataInterpreter.cxx
+++ b/chart2/source/model/template/XYDataInterpreter.cxx
@@ -36,8 +36,7 @@ using ::com::sun::star::uno::Sequence;
namespace chart
{
-XYDataInterpreter::XYDataInterpreter() :
- DataInterpreter()
+XYDataInterpreter::XYDataInterpreter()
{
}
diff --git a/chart2/source/tools/CachedDataSequence.cxx b/chart2/source/tools/CachedDataSequence.cxx
index 42b5249adc2b..112f1be6e439 100644
--- a/chart2/source/tools/CachedDataSequence.cxx
+++ b/chart2/source/tools/CachedDataSequence.cxx
@@ -83,9 +83,7 @@ CachedDataSequence::CachedDataSequence( const OUString & rSingleText )
}
CachedDataSequence::CachedDataSequence( const CachedDataSequence & rSource )
- : OMutexAndBroadcastHelper(),
- OPropertyContainer( GetBroadcastHelper()),
- OPropertyArrayUsageHelper< CachedDataSequence >(),
+ : OPropertyContainer( GetBroadcastHelper()),
CachedDataSequence_Base( GetMutex()),
m_nNumberFormatKey( rSource.m_nNumberFormatKey ),
m_sRole( rSource.m_sRole ),
diff --git a/chart2/source/tools/ExplicitCategoriesProvider.cxx b/chart2/source/tools/ExplicitCategoriesProvider.cxx
index e4782c95b28d..59ac20dd4640 100644
--- a/chart2/source/tools/ExplicitCategoriesProvider.cxx
+++ b/chart2/source/tools/ExplicitCategoriesProvider.cxx
@@ -48,7 +48,6 @@ ExplicitCategoriesProvider::ExplicitCategoriesProvider( const Reference< chart2:
: m_bDirty(true)
, m_xCooSysModel( xCooSysModel )
, mrModel(rModel)
- , m_xOriginalCategories()
, m_bIsExplicitCategoriesInited(false)
, m_bIsDateAxis(false)
, m_bIsAutoDate(false)
diff --git a/chart2/source/tools/LinearRegressionCurveCalculator.cxx b/chart2/source/tools/LinearRegressionCurveCalculator.cxx
index 811381507cb6..b4ec56028ec3 100644
--- a/chart2/source/tools/LinearRegressionCurveCalculator.cxx
+++ b/chart2/source/tools/LinearRegressionCurveCalculator.cxx
@@ -24,8 +24,7 @@ using namespace ::com::sun::star;
namespace chart
{
-LinearRegressionCurveCalculator::LinearRegressionCurveCalculator() :
- PolynomialRegressionCurveCalculator()
+LinearRegressionCurveCalculator::LinearRegressionCurveCalculator()
{}
LinearRegressionCurveCalculator::~LinearRegressionCurveCalculator()
diff --git a/chart2/source/tools/NameContainer.cxx b/chart2/source/tools/NameContainer.cxx
index b5e730ba552e..8879ededadee 100644
--- a/chart2/source/tools/NameContainer.cxx
+++ b/chart2/source/tools/NameContainer.cxx
@@ -39,7 +39,6 @@ NameContainer::NameContainer( const css::uno::Type& rType, const OUString& rServ
: m_aType( rType )
, m_aServicename( rServicename )
, m_aImplementationName( rImplementationName )
- , m_aMap()
{
}
diff --git a/chart2/source/tools/ObjectIdentifier.cxx b/chart2/source/tools/ObjectIdentifier.cxx
index 5f566f230c1d..dd23ec5d5338 100644
--- a/chart2/source/tools/ObjectIdentifier.cxx
+++ b/chart2/source/tools/ObjectIdentifier.cxx
@@ -242,7 +242,6 @@ void lcl_getDiagramAndCooSys( const OUString& rObjectCID
} //anonymous namespace
ObjectIdentifier::ObjectIdentifier()
- :m_aObjectCID( OUString() )
{
}
@@ -252,13 +251,11 @@ ObjectIdentifier::ObjectIdentifier( const OUString& rObjectCID )
}
ObjectIdentifier::ObjectIdentifier( const Reference< drawing::XShape >& rxShape )
- :m_aObjectCID( OUString() )
- ,m_xAdditionalShape( rxShape )
+ : m_xAdditionalShape( rxShape )
{
}
ObjectIdentifier::ObjectIdentifier( const Any& rAny )
- :m_aObjectCID( OUString() )
{
const uno::Type& rType = rAny.getValueType();
if ( rType == cppu::UnoType<OUString>::get() )
diff --git a/chart2/source/tools/UncachedDataSequence.cxx b/chart2/source/tools/UncachedDataSequence.cxx
index 1eae8def8f4e..d10fa7da3f37 100644
--- a/chart2/source/tools/UncachedDataSequence.cxx
+++ b/chart2/source/tools/UncachedDataSequence.cxx
@@ -83,9 +83,7 @@ UncachedDataSequence::UncachedDataSequence(
}
UncachedDataSequence::UncachedDataSequence( const UncachedDataSequence & rSource )
- : ::comphelper::OMutexAndBroadcastHelper(),
- OPropertyContainer( GetBroadcastHelper()),
- ::comphelper::OPropertyArrayUsageHelper< UncachedDataSequence >(),
+ : OPropertyContainer( GetBroadcastHelper()),
UncachedDataSequence_Base( GetMutex()),
m_nNumberFormatKey( rSource.m_nNumberFormatKey ),
m_sRole( rSource.m_sRole ),
diff --git a/chart2/source/view/axes/ScaleAutomatism.cxx b/chart2/source/view/axes/ScaleAutomatism.cxx
index f433a6bd076b..09da37aba034 100644
--- a/chart2/source/view/axes/ScaleAutomatism.cxx
+++ b/chart2/source/view/axes/ScaleAutomatism.cxx
@@ -64,7 +64,6 @@ ExplicitScaleData::ExplicitScaleData()
, Maximum(10.0)
, Origin(0.0)
, Orientation(css::chart2::AxisOrientation_MATHEMATICAL)
- , Scaling()
, AxisType(css::chart2::AxisType::REALNUMBER)
, ShiftedCategoryPosition(false)
, TimeResolution(css::chart::TimeUnit::DAY)
@@ -84,7 +83,6 @@ ExplicitIncrementData::ExplicitIncrementData()
, Distance(1.0)
, PostEquidistant(true)
, BaseValue(0.0)
- , SubIncrements()
{
}
diff --git a/chart2/source/view/axes/VAxisProperties.cxx b/chart2/source/view/axes/VAxisProperties.cxx
index c6e296e277ed..295ad21a68e6 100644
--- a/chart2/source/view/axes/VAxisProperties.cxx
+++ b/chart2/source/view/axes/VAxisProperties.cxx
@@ -168,9 +168,6 @@ AxisProperties::AxisProperties( const uno::Reference< XAxis >& xAxisModel
, m_nNumberFormatKey(0)
, m_nMajorTickmarks(1)
, m_nMinorTickmarks(1)
- , m_aTickmarkPropertiesList()
- , m_aLineProperties()
- //for category axes
, m_nAxisType(AxisType::REALNUMBER)
, m_bComplexCategories(false)
, m_pExplicitCategoriesProvider(pExplicitCategoriesProvider)
diff --git a/chart2/source/view/axes/VCoordinateSystem.cxx b/chart2/source/view/axes/VCoordinateSystem.cxx
index c9364b63a76a..ded24e5b1353 100644
--- a/chart2/source/view/axes/VCoordinateSystem.cxx
+++ b/chart2/source/view/axes/VCoordinateSystem.cxx
@@ -66,11 +66,9 @@ std::unique_ptr<VCoordinateSystem> VCoordinateSystem::createCoordinateSystem(
VCoordinateSystem::VCoordinateSystem( const Reference< XCoordinateSystem >& xCooSys )
: m_xCooSysModel(xCooSys)
- , m_aMatrixSceneToScreen()
, m_eLeftWallPos(CuboidPlanePosition_Left)
, m_eBackWallPos(CuboidPlanePosition_Back)
, m_eBottomPos(CuboidPlanePosition_Bottom)
- , m_aMergedMinMaxSupplier()
, m_aExplicitScales(3)
, m_aExplicitIncrements(3)
{
diff --git a/chart2/source/view/axes/VPolarAxis.cxx b/chart2/source/view/axes/VPolarAxis.cxx
index 9e41857c29d4..a12055aa5017 100644
--- a/chart2/source/view/axes/VPolarAxis.cxx
+++ b/chart2/source/view/axes/VPolarAxis.cxx
@@ -41,7 +41,6 @@ VPolarAxis::VPolarAxis( const AxisProperties& rAxisProperties
, sal_Int32 nDimensionIndex, sal_Int32 nDimensionCount )
: VAxisBase( nDimensionIndex, nDimensionCount, rAxisProperties, xNumberFormatsSupplier )
, m_pPosHelper( new PolarPlottingPositionHelper() )
- , m_aIncrements()
{
PlotterBase::m_pPosHelper = m_pPosHelper.get();
}
diff --git a/chart2/source/view/axes/VPolarGrid.cxx b/chart2/source/view/axes/VPolarGrid.cxx
index 46d176b6d91b..9233fd1d6472 100644
--- a/chart2/source/view/axes/VPolarGrid.cxx
+++ b/chart2/source/view/axes/VPolarGrid.cxx
@@ -42,7 +42,6 @@ VPolarGrid::VPolarGrid( sal_Int32 nDimensionIndex, sal_Int32 nDimensionCount
: VAxisOrGridBase( nDimensionIndex, nDimensionCount )
, m_aGridPropertiesList( rGridPropertiesList )
, m_pPosHelper( new PolarPlottingPositionHelper() )
- , m_aIncrements()
{
PlotterBase::m_pPosHelper = m_pPosHelper.get();
}
diff --git a/chart2/source/view/charttypes/PieChart.cxx b/chart2/source/view/charttypes/PieChart.cxx
index 08f94d00f513..37d0426b4734 100644
--- a/chart2/source/view/charttypes/PieChart.cxx
+++ b/chart2/source/view/charttypes/PieChart.cxx
@@ -893,7 +893,7 @@ void PieChart::createShapes()
}
PieChart::PieLabelInfo::PieLabelInfo()
- : aFirstPosition(), aOrigin(), fValue(0.0)
+ : fValue(0.0)
, bMovementAllowed(false), bMoved(false)
, bShowLeaderLine(false), pPrevious(nullptr)
, pNext(nullptr)
diff --git a/chart2/source/view/charttypes/VSeriesPlotter.cxx b/chart2/source/view/charttypes/VSeriesPlotter.cxx
index ee89ab640134..b0a591d3c065 100644
--- a/chart2/source/view/charttypes/VSeriesPlotter.cxx
+++ b/chart2/source/view/charttypes/VSeriesPlotter.cxx
@@ -104,7 +104,6 @@ VDataSeriesGroup::VDataSeriesGroup( std::unique_ptr<VDataSeries> pSeries )
: m_aSeriesVector(1)
, m_bMaxPointCountDirty(true)
, m_nMaxPointCount(0)
- , m_aListOfCachedYValues()
{
m_aSeriesVector[0] = std::move(pSeries);
}
@@ -144,11 +143,9 @@ VSeriesPlotter::VSeriesPlotter( const uno::Reference<XChartType>& xChartTypeMode
, m_pMainPosHelper( nullptr )
, m_xChartTypeModel(xChartTypeModel)
, m_xChartTypeModelProps( uno::Reference< beans::XPropertySet >::query( xChartTypeModel ))
- , m_aZSlots()
, m_bCategoryXAxis(bCategoryXAxis)
, m_nTimeResolution(css::chart::TimeUnit::DAY)
, m_aNullDate(30,12,1899)
- , m_xColorScheme()
, m_pExplicitCategoriesProvider(nullptr)
, m_bPointsWereSkipped(false)
, m_bPieLabelsAllowToMove(false)
diff --git a/chart2/source/view/diagram/VDiagram.cxx b/chart2/source/view/diagram/VDiagram.cxx
index bf3c96e82d53..d9b2eddd7cc0 100644
--- a/chart2/source/view/diagram/VDiagram.cxx
+++ b/chart2/source/view/diagram/VDiagram.cxx
@@ -47,7 +47,6 @@ VDiagram::VDiagram(
, m_nDimensionCount(nDimension)
, m_xDiagram(xDiagram)
, m_aPreferredAspectRatio(rPreferredAspectRatio)
- , m_xAspectRatio3D()
, m_fXAnglePi(0)
, m_fYAnglePi(0)
, m_fZAnglePi(0)
diff --git a/chart2/source/view/main/ChartView.cxx b/chart2/source/view/main/ChartView.cxx
index 7a02ba66b5d8..c9ef9f953bb6 100644
--- a/chart2/source/view/main/ChartView.cxx
+++ b/chart2/source/view/main/ChartView.cxx
@@ -1040,12 +1040,8 @@ const uno::Sequence<sal_Int8>& ExplicitValueProvider::getUnoTunnelId()
ChartView::ChartView(
uno::Reference<uno::XComponentContext> const & xContext,
ChartModel& rModel)
- : m_aMutex()
- , m_xCC(xContext)
+ : m_xCC(xContext)
, mrChartModel(rModel)
- , m_xShapeFactory()
- , m_xDrawPage()
- , m_pDrawModelWrapper()
, m_aListenerContainer( m_aMutex )
, m_bViewDirty(true)
, m_bInViewUpdate(false)
diff --git a/chart2/source/view/main/PlotterBase.cxx b/chart2/source/view/main/PlotterBase.cxx
index 9de0a8133b4e..b3311b023cbf 100644
--- a/chart2/source/view/main/PlotterBase.cxx
+++ b/chart2/source/view/main/PlotterBase.cxx
@@ -29,7 +29,6 @@ using namespace ::com::sun::star::chart2;
PlotterBase::PlotterBase( sal_Int32 nDimensionCount )
: m_pShapeFactory(nullptr)
- , m_aCID()
, m_nDimension(nDimensionCount)
, m_pPosHelper(nullptr)
{
diff --git a/chart2/source/view/main/PlottingPositionHelper.cxx b/chart2/source/view/main/PlottingPositionHelper.cxx
index 69a346b067e3..ae499fa82fb9 100644
--- a/chart2/source/view/main/PlottingPositionHelper.cxx
+++ b/chart2/source/view/main/PlottingPositionHelper.cxx
@@ -39,9 +39,7 @@ using namespace ::com::sun::star;
using namespace ::com::sun::star::chart2;
PlottingPositionHelper::PlottingPositionHelper()
- : m_aScales()
- , m_aMatrixScreenToScene()
- , m_bSwapXAndY( false )
+ : m_bSwapXAndY( false )
, m_nXResolution( 1000 )
, m_nYResolution( 1000 )
, m_nZResolution( 1000 )
@@ -316,7 +314,6 @@ drawing::Direction3D PlottingPositionHelper::getScaledLogicWidth() const
PolarPlottingPositionHelper::PolarPlottingPositionHelper()
: m_fRadiusOffset(0.0)
, m_fAngleDegreeOffset(90.0)
- , m_aUnitCartesianToScene()
{
m_bMaySkipPointsInRegressionCalculation = false;
}
diff --git a/chart2/source/view/main/VDataSeries.cxx b/chart2/source/view/main/VDataSeries.cxx
index 1135174c24d3..b3047d4126b3 100644
--- a/chart2/source/view/main/VDataSeries.cxx
+++ b/chart2/source/view/main/VDataSeries.cxx
@@ -144,22 +144,15 @@ VDataSeries::VDataSeries( const uno::Reference< XDataSeries >& xDataSeries )
, m_fLogicZPos(0.0)
, m_xDataSeries(xDataSeries)
, m_nPointCount(0)
-
, m_pValueSequenceForDataLabelNumberFormatDetection(&m_aValues_Y)
-
, m_fXMeanValue(std::numeric_limits<double>::quiet_NaN())
, m_fYMeanValue(std::numeric_limits<double>::quiet_NaN())
-
- , m_aAttributedDataPointIndexList()
-
, m_eStackingDirection(StackingDirection_NO_STACKING)
, m_nAxisIndex(0)
, m_bConnectBars(false)
, m_bGroupBarsPerAxis(true)
, m_nStartingAngle(90)
-
, m_nGlobalSeriesIndex(0)
-
, m_nCurrentAttributedPoint(-1)
, m_nMissingValueTreatment(css::chart::MissingValueTreatment::LEAVE_GAP)
, m_bAllowPercentValueInDataLabel(false)
diff --git a/chart2/source/view/main/VTitle.cxx b/chart2/source/view/main/VTitle.cxx
index ad2e857101fb..79d5d7a28256 100644
--- a/chart2/source/view/main/VTitle.cxx
+++ b/chart2/source/view/main/VTitle.cxx
@@ -32,7 +32,6 @@ using namespace ::com::sun::star::chart2;
VTitle::VTitle( const uno::Reference< XTitle > & xTitle )
: m_xTitle(xTitle)
- , m_aCID()
, m_fRotationAngleDegree(0.0)
, m_nXPos(0)
, m_nYPos(0)
More information about the Libreoffice-commits
mailing list