[Libreoffice-commits] core.git: Branch 'libreoffice-7-2-1' - svtools/source

Mike Kaganski (via logerrit) logerrit at kemper.freedesktop.org
Tue Aug 31 13:19:14 UTC 2021


 svtools/source/control/tabbar.cxx |    1 +
 1 file changed, 1 insertion(+)

New commits:
commit bf000215bcd524631b4f27ea4bc35229b48289f3
Author:     Mike Kaganski <mike.kaganski at collabora.com>
AuthorDate: Mon Aug 30 16:41:52 2021 +0200
Commit:     Adolfo Jayme Barrientos <fitojb at ubuntu.com>
CommitDate: Tue Aug 31 15:18:39 2021 +0200

    tdf#144183: restore 'erase' that was accidentally dropped
    
    ... in d47ac2ebdb495b025eb26e17cbbe2509797c31f0
    
    Change-Id: Ic4946b72a0ef599428af5b806754bda5f0906990
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121282
    Tested-by: Mike Kaganski <mike.kaganski at collabora.com>
    Reviewed-by: Mike Kaganski <mike.kaganski at collabora.com>
    (cherry picked from commit 638acd81979f24262c29dc12e0289d7fc38fcd8b)
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121284
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
    (cherry picked from commit bcc8fa6c0e5bcb6ca0da74a02427cf07e2abd0e7)
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121285
    Reviewed-by: Michael Stahl <michael.stahl at allotropia.de>
    Reviewed-by: Xisco Fauli <xiscofauli at libreoffice.org>
    Reviewed-by: Adolfo Jayme Barrientos <fitojb at ubuntu.com>
    Tested-by: Adolfo Jayme Barrientos <fitojb at ubuntu.com>

diff --git a/svtools/source/control/tabbar.cxx b/svtools/source/control/tabbar.cxx
index ae2c0e0d3e43..4bca7ccbb99d 100644
--- a/svtools/source/control/tabbar.cxx
+++ b/svtools/source/control/tabbar.cxx
@@ -1659,6 +1659,7 @@ void TabBar::MovePage(sal_uInt16 nPageId, sal_uInt16 nNewPos)
     auto it = mpImpl->maItemList.begin();
     it += nPos;
     ImplTabBarItem aItem = std::move(*it);
+    mpImpl->maItemList.erase(it);
     if (nNewPos < mpImpl->maItemList.size())
     {
         it = mpImpl->maItemList.begin();


More information about the Libreoffice-commits mailing list