[Libreoffice-commits] core.git: embeddedobj/source emfio/source extensions/source filter/source

Noel Grandin (via logerrit) logerrit at kemper.freedesktop.org
Tue Aug 31 15:29:38 UTC 2021


 embeddedobj/source/commonembedding/miscobj.cxx        |    2 -
 emfio/source/reader/mtftools.cxx                      |   27 ------------------
 emfio/source/reader/wmfreader.cxx                     |    1 
 extensions/source/logging/filehandler.cxx             |    2 -
 extensions/source/propctrlr/defaultforminspection.cxx |    3 --
 extensions/source/propctrlr/formgeometryhandler.cxx   |    1 
 extensions/source/propctrlr/objectinspectormodel.cxx  |    1 
 extensions/source/scanner/grid.cxx                    |    1 
 filter/source/config/cache/basecontainer.cxx          |    1 
 filter/source/config/cache/cacheitem.cxx              |    1 
 filter/source/msfilter/escherex.cxx                   |    2 -
 filter/source/msfilter/msdffimp.cxx                   |    1 
 filter/source/msfilter/svdfppt.cxx                    |    1 
 filter/source/pdf/impdialog.cxx                       |    1 
 filter/source/svg/svgfilter.cxx                       |    9 ------
 filter/source/svg/svgwriter.cxx                       |   13 --------
 16 files changed, 5 insertions(+), 62 deletions(-)

New commits:
commit 8508873a24387fefacd95e11e2ed9f2a0027ad43
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Tue Aug 31 14:54:07 2021 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Tue Aug 31 17:28:58 2021 +0200

    clang-tidy:readability-redundant-member-init
    
    Change-Id: Icaef0cca9ca7bce76a7eb7ecd54c492f9ffcaad6
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121376
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/embeddedobj/source/commonembedding/miscobj.cxx b/embeddedobj/source/commonembedding/miscobj.cxx
index 9427e0639b92..1e107e36c491 100644
--- a/embeddedobj/source/commonembedding/miscobj.cxx
+++ b/embeddedobj/source/commonembedding/miscobj.cxx
@@ -61,7 +61,6 @@ OCommonEmbeddedObject::OCommonEmbeddedObject( const uno::Reference< uno::XCompon
 , m_bIsLinkURL( false )
 , m_bLinkTempFileChanged( false )
 , m_bLinkHasPassword( false )
-, m_aLinkTempFile( )
 , m_bHasClonedSize( false )
 , m_nClonedMapUnit( 0 )
 {
@@ -88,7 +87,6 @@ OCommonEmbeddedObject::OCommonEmbeddedObject(
 , m_bIsLinkURL( true )
 , m_bLinkTempFileChanged( false )
 , m_bLinkHasPassword( false )
-, m_aLinkTempFile( )
 , m_bHasClonedSize( false )
 , m_nClonedMapUnit( 0 )
 {
diff --git a/emfio/source/reader/mtftools.cxx b/emfio/source/reader/mtftools.cxx
index ebc849430adc..93615d2c87d8 100644
--- a/emfio/source/reader/mtftools.cxx
+++ b/emfio/source/reader/mtftools.cxx
@@ -300,10 +300,6 @@ namespace emfio
 
     // tdf#127471
     ScaledFontDetectCorrectHelper::ScaledFontDetectCorrectHelper()
-    :   maCurrentMetaFontAction(),
-        maAlternativeFontScales(),
-        maPositiveIdentifiedCases(),
-        maNegativeIdentifiedCases()
     {
     }
 
@@ -1098,21 +1094,8 @@ namespace emfio
     }
 
     MtfTools::MtfTools( GDIMetaFile& rGDIMetaFile, SvStream& rStreamWMF)
-    :   maPathObj(),
-        maClipPath(),
-        maLatestLineStyle(),
-        maLineStyle(),
-        maNopLineStyle(),
-        maLatestFillStyle(),
-        maFillStyle(),
-        maNopFillStyle(),
-        maPalette(),
-        maLatestFont(),
-        maFont(),
-        mnLatestTextAlign(90),
+    :   mnLatestTextAlign(90),
         mnTextAlign(TA_LEFT | TA_TOP | TA_NOUPDATECP),
-        maLatestTextColor(),
-        maTextColor(),
         maLatestBkColor(ColorTransparency, 0x12345678),
         maBkColor(COL_WHITE),
         mnLatestTextLayoutMode(ComplexTextLayoutFlags::Default),
@@ -1121,13 +1104,9 @@ namespace emfio
         mnBkMode(BkMode::OPAQUE),
         meLatestRasterOp(RasterOp::Invert),
         meRasterOp(RasterOp::OverPaint),
-        mvGDIObj(),
-        maActPos(),
         mnRop(),
-        mvSaveStack(),
         mnGfxMode(GM_COMPATIBLE),
         mnMapMode(MM_TEXT),
-        maXForm(),
         mnDevOrgX(0),
         mnDevOrgY(0),
         mnDevWidth(1),
@@ -1140,14 +1119,10 @@ namespace emfio
         mnPixY(100),
         mnMillX(1),
         mnMillY(1),
-        mrclFrame(),
-        mrclBounds(),
         mpGDIMetaFile(&rGDIMetaFile),
         mpInputStream(&rStreamWMF),
         mnStartPos(0),
         mnEndPos(0),
-        maBmpSaveList(),
-        maScaledFontHelper(),
         mbNopMode(false),
         mbFillStyleSelected(false),
         mbClipNeedsUpdate(true),
diff --git a/emfio/source/reader/wmfreader.cxx b/emfio/source/reader/wmfreader.cxx
index afabb795f8e0..6ef7003c42bd 100644
--- a/emfio/source/reader/wmfreader.cxx
+++ b/emfio/source/reader/wmfreader.cxx
@@ -2015,7 +2015,6 @@ namespace emfio
         : MtfTools(rGDIMetaFile, rStreamWMF)
         , mnUnitsPerInch(96)
         , mnRecSize(0)
-        , mpEMFStream()
         , mnEMFRecCount(0)
         , mnEMFRec(0)
         , mnEMFSize(0)
diff --git a/extensions/source/logging/filehandler.cxx b/extensions/source/logging/filehandler.cxx
index 222146b0b4d2..200a3a64bbd0 100644
--- a/extensions/source/logging/filehandler.cxx
+++ b/extensions/source/logging/filehandler.cxx
@@ -130,8 +130,6 @@ namespace logging
         :FileHandler_Base( m_aMutex )
         ,m_xContext( context )
         ,m_aHandlerHelper( context, m_aMutex, rBHelper )
-        ,m_sFileURL( )
-        ,m_pFile( )
         ,m_eFileValidity( eUnknown )
     {
         ::osl::MutexGuard aGuard( m_aMutex );
diff --git a/extensions/source/propctrlr/defaultforminspection.cxx b/extensions/source/propctrlr/defaultforminspection.cxx
index a2b1d2d26ea1..0ecb9815ac4a 100644
--- a/extensions/source/propctrlr/defaultforminspection.cxx
+++ b/extensions/source/propctrlr/defaultforminspection.cxx
@@ -44,8 +44,7 @@ namespace pcr
     using ::com::sun::star::lang::IllegalArgumentException;
 
     DefaultFormComponentInspectorModel::DefaultFormComponentInspectorModel( bool _bUseFormFormComponentHandlers )
-        :ImplInspectorModel()
-        ,m_bUseFormComponentHandlers( _bUseFormFormComponentHandlers )
+        :m_bUseFormComponentHandlers( _bUseFormFormComponentHandlers )
         ,m_bConstructed( false )
         ,m_pInfoService( new OPropertyInfoService )
     {
diff --git a/extensions/source/propctrlr/formgeometryhandler.cxx b/extensions/source/propctrlr/formgeometryhandler.cxx
index 0372087036ce..f33ee1a6df78 100644
--- a/extensions/source/propctrlr/formgeometryhandler.cxx
+++ b/extensions/source/propctrlr/formgeometryhandler.cxx
@@ -134,7 +134,6 @@ namespace pcr
         ShapeGeometryChangeNotifier( ::cppu::OWeakObject& _rParent, ::osl::Mutex& _rParentMutex, const Reference< XShape >& _shape )
             :BroadcastHelperBase( _rParentMutex )
             ,ShapeGeometryChangeNotifier_CBase( BroadcastHelperBase::getBroadcastHelper(), ::comphelper::ComponentBase::NoInitializationNeeded() )
-            ,ShapeGeometryChangeNotifier_IBase()
             ,m_rParent( _rParent )
             ,m_aPropertyChangeListeners( _rParentMutex )
             ,m_xShape( _shape )
diff --git a/extensions/source/propctrlr/objectinspectormodel.cxx b/extensions/source/propctrlr/objectinspectormodel.cxx
index e320a0f8f24b..c0f6bf6b703e 100644
--- a/extensions/source/propctrlr/objectinspectormodel.cxx
+++ b/extensions/source/propctrlr/objectinspectormodel.cxx
@@ -79,7 +79,6 @@ namespace pcr
     //= ObjectInspectorModel
 
     ObjectInspectorModel::ObjectInspectorModel()
-        :ImplInspectorModel()
     {
     }
 
diff --git a/extensions/source/scanner/grid.cxx b/extensions/source/scanner/grid.cxx
index 536ead40b069..b3ab1542f083 100644
--- a/extensions/source/scanner/grid.cxx
+++ b/extensions/source/scanner/grid.cxx
@@ -154,7 +154,6 @@ GridWindow::GridWindow()
     , m_BmOffX(0)
     , m_BmOffY(0)
     , m_bCutValues(false)
-    , m_aHandles()
     , m_nDragIndex(npos)
 {
 }
diff --git a/filter/source/config/cache/basecontainer.cxx b/filter/source/config/cache/basecontainer.cxx
index 023afd29415a..10dd76d82d3e 100644
--- a/filter/source/config/cache/basecontainer.cxx
+++ b/filter/source/config/cache/basecontainer.cxx
@@ -34,7 +34,6 @@ namespace filter::config{
 
 BaseContainer::BaseContainer()
     : BaseLock     (       )
-    , m_pFlushCache()
     , m_eType()
     , m_lListener  (m_aLock)
 {
diff --git a/filter/source/config/cache/cacheitem.cxx b/filter/source/config/cache/cacheitem.cxx
index fd8af23fe3ce..a406b16ff130 100644
--- a/filter/source/config/cache/cacheitem.cxx
+++ b/filter/source/config/cache/cacheitem.cxx
@@ -33,7 +33,6 @@
 namespace filter::config{
 
 CacheItem::CacheItem()
-    : SequenceAsHashMap()
 {
 }
 
diff --git a/filter/source/msfilter/escherex.cxx b/filter/source/msfilter/escherex.cxx
index 240e3146eea3..865df7c292b4 100644
--- a/filter/source/msfilter/escherex.cxx
+++ b/filter/source/msfilter/escherex.cxx
@@ -4853,7 +4853,7 @@ protected:
     virtual void FlushData() override {}
 
 public:
-    SvNullStream() : SvStream() {}
+    SvNullStream()  {}
 };
 
 }
diff --git a/filter/source/msfilter/msdffimp.cxx b/filter/source/msfilter/msdffimp.cxx
index 0fde06b7e7af..dc03c9355261 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -7425,7 +7425,6 @@ SvxMSDffImportRec::SvxMSDffImportRec()
       nCropFromBottom( 0 ),
       nCropFromLeft( 0 ),
       nCropFromRight( 0 ),
-      aTextId(),
       nNextShapeId( 0 ),
       nShapeId( 0 ),
       eShapeType( mso_sptNil ),
diff --git a/filter/source/msfilter/svdfppt.cxx b/filter/source/msfilter/svdfppt.cxx
index 0d59afdc132f..15e70779e868 100644
--- a/filter/source/msfilter/svdfppt.cxx
+++ b/filter/source/msfilter/svdfppt.cxx
@@ -4460,7 +4460,6 @@ PPTParaPropSet& PPTParaPropSet::operator=( const PPTParaPropSet& rParaPropSet )
 PPTCharPropSet::PPTCharPropSet(sal_uInt32 nParagraph)
     : mnOriginalTextPos(0)
     , mnParagraph(nParagraph)
-    , mpImplPPTCharPropSet()
 {
     mnHylinkOrigColor = 0;
     mbIsHyperlink = false;
diff --git a/filter/source/pdf/impdialog.cxx b/filter/source/pdf/impdialog.cxx
index 0e5a4441907e..ca46732cc174 100644
--- a/filter/source/pdf/impdialog.cxx
+++ b/filter/source/pdf/impdialog.cxx
@@ -1505,7 +1505,6 @@ IMPL_LINK_NOARG(ImplErrorDialog, SelectHdl, weld::TreeView&, void)
 /// The digital signatures tab page
 ImpPDFTabSigningPage::ImpPDFTabSigningPage(weld::Container* pPage, weld::DialogController* pController, const SfxItemSet& rCoreSet)
     : SfxTabPage(pPage, pController, "filter/ui/pdfsignpage.ui", "PdfSignPage", &rCoreSet)
-    , maSignCertificate()
     , mxEdSignCert(m_xBuilder->weld_entry("cert"))
     , mxPbSignCertSelect(m_xBuilder->weld_button("select"))
     , mxPbSignCertClear(m_xBuilder->weld_button("clear"))
diff --git a/filter/source/svg/svgfilter.cxx b/filter/source/svg/svgfilter.cxx
index d8a40437040c..2843e7df9637 100644
--- a/filter/source/svg/svgfilter.cxx
+++ b/filter/source/svg/svgfilter.cxx
@@ -75,18 +75,12 @@ SVGFilter::SVGFilter( const Reference< XComponentContext >& rxCtx ) :
     mbSinglePage( false ),
     mnVisiblePage( -1 ),
     mpObjects( nullptr ),
-    mxSrcDoc(),
-    mxDstDoc(),
-    maShapeSelection(),
     mbExportShapeSelection(false),
-    maFilterData(),
-    mxDefaultPage(),
     mbWriterFilter(false),
     mbCalcFilter(false),
     mbImpressFilter(false),
     mpDefaultSdrPage( nullptr ),
-    mbPresentation( false ),
-    maOldFieldHdl()
+    mbPresentation( false )
 {
 }
 
@@ -721,7 +715,6 @@ public:
     SVGFileInfo(
         const uno::Reference<io::XInputStream>& xInput)
     :   mxInput(xInput),
-        mnFirstBytes(),
         mnFirstBytesSize(2048),
         mnFirstRead(0),
         mbProcessed(false),
diff --git a/filter/source/svg/svgwriter.cxx b/filter/source/svg/svgwriter.cxx
index 05d18bc3675c..082d7d8b0377 100644
--- a/filter/source/svg/svgwriter.cxx
+++ b/filter/source/svg/svgwriter.cxx
@@ -463,12 +463,6 @@ SVGTextWriter::SVGTextWriter(SVGExport& rExport, SVGAttributeWriter& rAttributeW
   mrActionWriter(rActionWriter),
   mpVDev( nullptr ),
   mbIsTextShapeStarted( false ),
-  mrTextShape(),
-  msShapeId(),
-  mrParagraphEnumeration(),
-  mrCurrentTextParagraph(),
-  mrTextPortionEnumeration(),
-  mrCurrentTextPortion(),
   mpTextEmbeddedBitmapMtf( nullptr ),
   mpTargetMapMode( nullptr ),
   mnLeftTextPortionLength( 0 ),
@@ -478,14 +472,10 @@ SVGTextWriter::SVGTextWriter(SVGExport& rExport, SVGAttributeWriter& rAttributeW
   mbIsNewListItem( false ),
   meNumberingType(0),
   mcBulletChar(0),
-  maBulletListItemMap(),
   mbIsListLevelStyleImage( false ),
   mbLineBreak( false ),
   mbIsURLField( false ),
-  msUrl(),
-  mbIsPlaceholderShape( false ),
-  maCurrentFont(),
-  maParentFont()
+  mbIsPlaceholderShape( false )
 {
 }
 
@@ -1786,7 +1776,6 @@ SVGActionWriter::SVGActionWriter( SVGExport& rExport, SVGFontExport& rFontExport
     mnCurMaskId( 1 ),
     mnCurPatternId( 1 ),
     mnCurClipPathId( 1 ),
-    mpCurrentClipRegionElem(),
     mrExport( rExport ),
     maContextHandler(),
     mrCurrentState( maContextHandler.getCurrentState() ),


More information about the Libreoffice-commits mailing list