[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - sc/source

Ouyang Leyan (via logerrit) logerrit at kemper.freedesktop.org
Wed Feb 3 19:35:05 UTC 2021


 sc/source/core/data/column.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a7997a44d20a78bc7aecbd0518528522cd041e16
Author:     Ouyang Leyan <ouyang.leyan at hotmail.com>
AuthorDate: Fri Jan 8 22:16:41 2021 +0100
Commit:     Xisco Fauli <xiscofauli at libreoffice.org>
CommitDate: Wed Feb 3 20:34:27 2021 +0100

    tdf#120348: Avoid data loss when copying chart with error in formulas
    
    During a chart copy in Calc, when skipping cells with ERR:502 in values,
    the rest of the column was skipped as well, including valid values.
    
    Change-Id: I2578dfdefe9d006de572f8faa3a8cc32e9f55010
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109025
    Tested-by: Jenkins
    Reviewed-by: Eike Rathke <erack at redhat.com>
    (cherry picked from commit 318d384c596c1593667d6c936f55bf6ebd0c5db6)
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110355
    Reviewed-by: Xisco Fauli <xiscofauli at libreoffice.org>

diff --git a/sc/source/core/data/column.cxx b/sc/source/core/data/column.cxx
index 61011da9aeae..b20fbdb16f7b 100644
--- a/sc/source/core/data/column.cxx
+++ b/sc/source/core/data/column.cxx
@@ -1148,7 +1148,7 @@ void ScColumn::CopyStaticToDocument(
 
                     if (rFC.GetErrCode() != FormulaError::NONE)
                         // Skip cells with error.
-                        break;
+                        continue;
 
                     if (rFC.IsValue())
                         aDestPos.miCellPos = rDestCol.maCells.set(aDestPos.miCellPos, nRow, rFC.GetValue());


More information about the Libreoffice-commits mailing list