[Libreoffice-commits] core.git: sc/source

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Fri Feb 5 10:35:41 UTC 2021


 sc/source/ui/view/cellsh1.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 8b15deceaa54ed20c2ce4199cd54baaec26ae2c2
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Fri Feb 5 09:14:27 2021 +0000
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Fri Feb 5 11:35:01 2021 +0100

    cid#1472785 Dereference before null check
    
    Change-Id: I6e07e76be11b52873ee27054f7317996701223a1
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110456
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sc/source/ui/view/cellsh1.cxx b/sc/source/ui/view/cellsh1.cxx
index 8056fccb01f8..6b1c50b3e011 100644
--- a/sc/source/ui/view/cellsh1.cxx
+++ b/sc/source/ui/view/cellsh1.cxx
@@ -2787,7 +2787,7 @@ void ScCellShell::ExecuteEdit( SfxRequest& rReq )
 
                 ScInputHandler* pInputHdl = SC_MOD()->GetInputHdl();
 
-                if(param3 && param4 && pInputHdl && pTabViewShell)
+                if (param3 && param4 && pInputHdl)
                 {
                     ScViewData& rData = pTabViewShell->GetViewData();
                     ScTabView* pTabView = rData.GetView();


More information about the Libreoffice-commits mailing list