[Libreoffice-commits] core.git: sc/qa

Xisco Fauli (via logerrit) logerrit at kemper.freedesktop.org
Sat Feb 6 00:09:44 UTC 2021


 sc/qa/uitest/calc_tests9/tdf133629.py |   18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

New commits:
commit faadf530c22d1874640936b8554845d7ff36f263
Author:     Xisco Fauli <xiscofauli at libreoffice.org>
AuthorDate: Fri Feb 5 22:47:55 2021 +0100
Commit:     Xisco Fauli <xiscofauli at libreoffice.org>
CommitDate: Sat Feb 6 01:08:58 2021 +0100

    uitest: sc: just check one cell instead of the whole sheet
    
    otherwise, it fails sometimes
    
    Change-Id: Ic8aac34538b5c4914a107b375d87f2ad98090c31
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110494
    Tested-by: Jenkins
    Reviewed-by: Xisco Fauli <xiscofauli at libreoffice.org>

diff --git a/sc/qa/uitest/calc_tests9/tdf133629.py b/sc/qa/uitest/calc_tests9/tdf133629.py
index 32f31512fdfb..2b13645420ec 100644
--- a/sc/qa/uitest/calc_tests9/tdf133629.py
+++ b/sc/qa/uitest/calc_tests9/tdf133629.py
@@ -35,7 +35,7 @@ class tdf133629(UITestCase):
         select_pos(xTabs, "5")
 
         xPresets = xDialog.getChild("presets")
-        xPresets.executeAction("CHOOSE", mkPropertyValues({"POS": "3"}))
+        xPresets.executeAction("CHOOSE", mkPropertyValues({"POS": "4"}))
 
         # Change width
         xLineWidth = xDialog.getChild("linewidthmf")
@@ -48,13 +48,17 @@ class tdf133629(UITestCase):
 
         # Without the fix in place, this test would have crash here
 
-        self.assertEqual(44, document.Sheets[0].TableBorder.BottomLine.OuterLineWidth)
-        self.assertEqual(44, document.Sheets[0].TableBorder.LeftLine.OuterLineWidth)
-        self.assertEqual(44, document.Sheets[0].TableBorder.TopLine.OuterLineWidth)
+        xA1Sheet1 = document.Sheets[0].getCellRangeByName("A1")
+        self.assertEqual(44, xA1Sheet1.BottomBorder.OuterLineWidth)
+        self.assertEqual(44, xA1Sheet1.TopBorder.OuterLineWidth)
+        self.assertEqual(44, xA1Sheet1.LeftBorder.OuterLineWidth)
+        self.assertEqual(44, xA1Sheet1.RightBorder.OuterLineWidth)
 
-        self.assertEqual(44, document.Sheets[1].TableBorder.BottomLine.OuterLineWidth)
-        self.assertEqual(44, document.Sheets[1].TableBorder.LeftLine.OuterLineWidth)
-        self.assertEqual(44, document.Sheets[1].TableBorder.TopLine.OuterLineWidth)
+        xA1Sheet2 = document.Sheets[1].getCellRangeByName("A1")
+        self.assertEqual(44, xA1Sheet2.BottomBorder.OuterLineWidth)
+        self.assertEqual(44, xA1Sheet2.TopBorder.OuterLineWidth)
+        self.assertEqual(44, xA1Sheet2.LeftBorder.OuterLineWidth)
+        self.assertEqual(44, xA1Sheet2.RightBorder.OuterLineWidth)
 
         self.ui_test.close_doc()
 


More information about the Libreoffice-commits mailing list