[Libreoffice-commits] core.git: xmloff/source

Andrea Gelmini (via logerrit) logerrit at kemper.freedesktop.org
Sun Feb 7 08:44:38 UTC 2021


 xmloff/source/chart/SchXMLAxisContext.cxx         |    1 -
 xmloff/source/chart/XMLChartPropertyContext.cxx   |    2 --
 xmloff/source/draw/XMLShapePropertySetContext.cxx |    2 --
 xmloff/source/draw/sdxmlimp.cxx                   |    1 -
 xmloff/source/draw/shapeimport.cxx                |    1 -
 xmloff/source/draw/ximpbody.cxx                   |    1 -
 xmloff/source/draw/ximpstyl.cxx                   |    3 ---
 7 files changed, 11 deletions(-)

New commits:
commit 96a38db6e5e9c6a333a3a5c268798edb2ce2d466
Author:     Andrea Gelmini <andrea.gelmini at gelma.net>
AuthorDate: Sat Feb 6 20:34:19 2021 +0100
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Sun Feb 7 09:44:01 2021 +0100

    Remove unneeded breaks on xmloff/
    
    Extending this:
    https://gerrit.libreoffice.org/c/core/+/110512
    
    I add a simple check about the subject.
    
    Change-Id: Iec63299f5c0a03f2ddd0e06549ddc9dba0fb28fd
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110514
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/xmloff/source/chart/SchXMLAxisContext.cxx b/xmloff/source/chart/SchXMLAxisContext.cxx
index 13bec6e8e15a..2f312c7e21b1 100644
--- a/xmloff/source/chart/SchXMLAxisContext.cxx
+++ b/xmloff/source/chart/SchXMLAxisContext.cxx
@@ -598,7 +598,6 @@ css::uno::Reference< css::xml::sax::XFastContextHandler > SchXMLAxisContext::cre
         case  XML_ELEMENT(CHART_EXT, XML_DATE_SCALE):
             m_bDateScaleImported = true;
             return new DateScaleContext( GetImport(), m_xAxisProps );
-            break;
 
         case XML_ELEMENT(CHART, XML_GRID):
         {
diff --git a/xmloff/source/chart/XMLChartPropertyContext.cxx b/xmloff/source/chart/XMLChartPropertyContext.cxx
index 83cc7bb9aaf8..d39b36bfc3ad 100644
--- a/xmloff/source/chart/XMLChartPropertyContext.cxx
+++ b/xmloff/source/chart/XMLChartPropertyContext.cxx
@@ -53,10 +53,8 @@ css::uno::Reference< css::xml::sax::XFastContextHandler > XMLChartPropertyContex
     {
         case XML_SCH_CONTEXT_SPECIAL_SYMBOL_IMAGE:
             return new XMLSymbolImageContext( GetImport(), nElement, rProp, rProperties );
-            break;
         case XML_SCH_CONTEXT_SPECIAL_LABEL_SEPARATOR:
             return new XMLLabelSeparatorContext( GetImport(), nElement, rProp, rProperties );
-            break;
     }
 
     // default / no context yet: create child context by base class
diff --git a/xmloff/source/draw/XMLShapePropertySetContext.cxx b/xmloff/source/draw/XMLShapePropertySetContext.cxx
index b8bc00122044..456dc215b9db 100644
--- a/xmloff/source/draw/XMLShapePropertySetContext.cxx
+++ b/xmloff/source/draw/XMLShapePropertySetContext.cxx
@@ -74,12 +74,10 @@ css::uno::Reference< css::xml::sax::XFastContextHandler > XMLShapePropertySetCon
         mnBulletIndex = rProp.mnIndex;
         mxBulletStyle = new SvxXMLListStyleContext( GetImport() );
         return mxBulletStyle.get();
-        break;
     case CTF_TABSTOP:
         return new SvxXMLTabStopImportContext( GetImport(), nElement,
                                                    rProp,
                                                    rProperties );
-        break;
     }
 
     return SvXMLPropertySetContext::createFastChildContext( nElement,
diff --git a/xmloff/source/draw/sdxmlimp.cxx b/xmloff/source/draw/sdxmlimp.cxx
index ae5dba2c6639..b768eaf14d32 100644
--- a/xmloff/source/draw/sdxmlimp.cxx
+++ b/xmloff/source/draw/sdxmlimp.cxx
@@ -162,7 +162,6 @@ uno::Reference< xml::sax::XFastContextHandler > SAL_CALL SdXMLDocContext_Impl::c
         case XML_ELEMENT(OFFICE, XML_FONT_FACE_DECLS):
         {
             return GetSdImport().CreateFontDeclsContext();
-            break;
         }
         case XML_ELEMENT(OFFICE, XML_META):
         {
diff --git a/xmloff/source/draw/shapeimport.cxx b/xmloff/source/draw/shapeimport.cxx
index c2fb5999fdea..a68105ea4b70 100644
--- a/xmloff/source/draw/shapeimport.cxx
+++ b/xmloff/source/draw/shapeimport.cxx
@@ -350,7 +350,6 @@ SvXMLShapeContext* XMLShapeImportHelper::CreateGroupChildContext(
         }
         case XML_ELEMENT(DRAW, XML_A):
             return new SdXMLShapeLinkContext( rImport, xAttrList, rShapes );
-            break;
         // add other shapes here...
         default:
             XMLOFF_WARN_UNKNOWN_ELEMENT("xmloff", nElement);
diff --git a/xmloff/source/draw/ximpbody.cxx b/xmloff/source/draw/ximpbody.cxx
index 1fb556828199..f6dad065d9f6 100644
--- a/xmloff/source/draw/ximpbody.cxx
+++ b/xmloff/source/draw/ximpbody.cxx
@@ -336,7 +336,6 @@ css::uno::Reference< css::xml::sax::XFastContextHandler > SdXMLBodyContext::crea
         case XML_ELEMENT(PRESENTATION, XML_DATE_TIME_DECL):
         {
             return new SdXMLHeaderFooterDeclContext( GetImport(), xAttrList );
-            break;
         }
         default:
             XMLOFF_WARN_UNKNOWN_ELEMENT("xmloff", nElement);
diff --git a/xmloff/source/draw/ximpstyl.cxx b/xmloff/source/draw/ximpstyl.cxx
index ac23bc3345a2..05ecaf377eec 100644
--- a/xmloff/source/draw/ximpstyl.cxx
+++ b/xmloff/source/draw/ximpstyl.cxx
@@ -896,12 +896,10 @@ SvXMLStyleContext* SdXMLStylesContext::CreateStyleStyleChildContext(
     {
     case XmlStyleFamily::SD_DRAWINGPAGE_ID:
         return new SdXMLDrawingPageStyleContext(GetSdImport(), *this );
-        break;
     case XmlStyleFamily::TABLE_CELL:
     case XmlStyleFamily::TABLE_COLUMN:
     case XmlStyleFamily::TABLE_ROW:
         return new XMLShapeStyleContext( GetSdImport(), *this, nFamily );
-        break;
     default: break;
     }
 
@@ -918,7 +916,6 @@ SvXMLStyleContext* SdXMLStylesContext::CreateDefaultStyleStyleChildContext(
     {
     case XmlStyleFamily::SD_GRAPHICS_ID:
         return new XMLGraphicsDefaultStyle(GetSdImport(), *this );
-        break;
     default: break;
     }
 


More information about the Libreoffice-commits mailing list