[Libreoffice-commits] core.git: vcl/jsdialog

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Wed Feb 10 14:46:16 UTC 2021


 vcl/jsdialog/executor.cxx |    6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

New commits:
commit 38ed6b173ce3cc11b3b4f99344e75edaf6ab735d
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Wed Feb 10 09:51:55 2021 +0000
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Wed Feb 10 15:45:29 2021 +0100

    cid#1472858 Unchecked dynamic_cast
    
    Change-Id: I3103719f6184efb7b9ecfb6d589d6757449814cd
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110693
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/vcl/jsdialog/executor.cxx b/vcl/jsdialog/executor.cxx
index 53f70630fe1c..8c76e77d8b37 100644
--- a/vcl/jsdialog/executor.cxx
+++ b/vcl/jsdialog/executor.cxx
@@ -37,12 +37,8 @@ StringMap jsonToStringMap(const char* pJSON)
 void SendFullUpdate(sal_uInt64 nWindowId, const OString& rWidget)
 {
     weld::Widget* pWidget = JSInstanceBuilder::FindWeldWidgetsMap(nWindowId, rWidget);
-
-    if (pWidget != nullptr)
-    {
-        auto pJSWidget = dynamic_cast<BaseJSWidget*>(pWidget);
+    if (auto pJSWidget = dynamic_cast<BaseJSWidget*>(pWidget))
         pJSWidget->sendFullUpdate();
-    }
 }
 
 bool ExecuteAction(sal_uInt64 nWindowId, const OString& rWidget, StringMap& rData)


More information about the Libreoffice-commits mailing list