[Libreoffice-commits] core.git: sfx2/source sfx2/uiconfig

Tomaž Vajngerl (via logerrit) logerrit at kemper.freedesktop.org
Mon Feb 22 05:30:10 UTC 2021


 sfx2/source/devtools/ObjectInspectorTreeHandler.cxx |    6 ++++--
 sfx2/uiconfig/ui/developmenttool.ui                 |   14 ++++++++++++++
 2 files changed, 18 insertions(+), 2 deletions(-)

New commits:
commit 460c778bd483fb0a61c4b0d46f5f876ce80dff26
Author:     Tomaž Vajngerl <tomaz.vajngerl at collabora.co.uk>
AuthorDate: Mon Feb 22 09:15:39 2021 +0900
Commit:     Tomaž Vajngerl <quikee at gmail.com>
CommitDate: Mon Feb 22 06:29:27 2021 +0100

    devtools: add implementation class to the methods category
    
    Implementation class is the class where the method is implemented
    on.
    
    Change-Id: Ia415ce96a821b4335e1f378b6b7773548fd3e705
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111293
    Tested-by: Jenkins
    Reviewed-by: Tomaž Vajngerl <quikee at gmail.com>

diff --git a/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx b/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
index 39f2d70eb06a..e672d256fbe6 100644
--- a/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
+++ b/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx
@@ -301,12 +301,11 @@ public:
 
     std::vector<std::pair<sal_Int32, OUString>> getColumnValues() override
     {
-        OUString aInString;
         OUString aOutString;
-
         auto xClass = mxMethod->getReturnType();
         aOutString = simpleTypeName(xClass);
 
+        OUString aInString;
         const auto aParameters = mxMethod->getParameterInfos();
         bool bFirst = true;
         for (auto const& rParameterInfo : aParameters)
@@ -334,9 +333,12 @@ public:
             aInString += rParameterInfo.aName + " : " + simpleTypeName(rParameterInfo.aType);
         }
 
+        OUString aImplementationClass = mxMethod->getDeclaringClass()->getName();
+
         return {
             { 1, aOutString },
             { 2, aInString },
+            { 3, aImplementationClass },
         };
     }
 
diff --git a/sfx2/uiconfig/ui/developmenttool.ui b/sfx2/uiconfig/ui/developmenttool.ui
index 9dd110804991..3eeb94859885 100644
--- a/sfx2/uiconfig/ui/developmenttool.ui
+++ b/sfx2/uiconfig/ui/developmenttool.ui
@@ -26,6 +26,8 @@
       <column type="gchararray"/>
       <!-- column-name in -->
       <column type="gchararray"/>
+      <!-- column-name impl -->
+      <column type="gchararray"/>
       <!-- column-name id -->
       <column type="gchararray"/>
     </columns>
@@ -407,6 +409,18 @@
                             </child>
                           </object>
                         </child>
+                        <child>
+                          <object class="GtkTreeViewColumn" id="treeviewcolumn13">
+                            <property name="resizable">True</property>
+                            <property name="title" translatable="yes" context="developmenttool|implementation_class">Implementation Class</property>
+                            <child>
+                              <object class="GtkCellRendererText" id="obj_insp_cellrenderertext13"/>
+                              <attributes>
+                                <attribute name="text">3</attribute>
+                              </attributes>
+                            </child>
+                          </object>
+                        </child>
                       </object>
                     </child>
                   </object>


More information about the Libreoffice-commits mailing list