[Libreoffice-commits] core.git: vcl/jsdialog

[Caolán McNamara (via logerrit)]

 vcl/jsdialog/jsdialogbuilder.cxx |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

New commits:
commit 0c20b68149797c8b0779534a8e0cb9045085d451
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Fri Jan 8 20:28:42 2021 +0000
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Sat Jan 9 13:00:29 2021 +0100

    cid#1470783 Logically dead code
    
    Change-Id: I0bf96d28904b84bb970c53d0cb732dc45aa2deb0
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109020
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/vcl/jsdialog/jsdialogbuilder.cxx b/vcl/jsdialog/jsdialogbuilder.cxx
index 19f8780d2740..c3e783452452 100644
--- a/vcl/jsdialog/jsdialogbuilder.cxx
+++ b/vcl/jsdialog/jsdialogbuilder.cxx
@@ -448,9 +448,8 @@ std::unique_ptr<weld::Dialog> JSInstanceBuilder::weld_dialog(const OString& id)
         if (id == "MacroSelectorDialog")
             pDialog->SetDisableIdleNotify(true);
 
-        pRet.reset(pDialog ? new JSDialog(m_aOwnedToplevel, m_aOwnedToplevel, pDialog, this, false,
-                                          m_sTypeOfJSON)
-                           : nullptr);
+        pRet.reset(
+            new JSDialog(m_aOwnedToplevel, m_aOwnedToplevel, pDialog, this, false, m_sTypeOfJSON));
 
         RememberWidget("__DIALOG__", pRet.get());