[Libreoffice-commits] core.git: chart2/source

Stephan Bergmann (via logerrit) logerrit at kemper.freedesktop.org
Tue Jan 12 10:42:08 UTC 2021


 chart2/source/controller/sidebar/ChartLinePanel.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b606d484a696faef7c7caa1bcc6afab8f514c7a0
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Mon Jan 11 11:00:26 2021 +0100
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Tue Jan 12 11:41:23 2021 +0100

    -Werror=maybe-uninitialized
    
    ...in code introduced with 00140e3df4a22e75261de3af18c6c0fc3f5fc92c "lok: send
    chart line width updates".  Falling back to zero is in line with the preceding,
    similar
    
      sal_uInt16 nLineTransparence = 0;
      ...
    
    block (introduced with 3dc00a8de9f9f1b1ad0c60134391638544cdd143 "handle line
    dash in chart line panel"), but using o3tl::doAccess or o3tl::forceAccess might
    be more appropriate.
    
    Change-Id: I8c2286b386aa9052d1d2af0f9f25847829ca4df5
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109081
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/chart2/source/controller/sidebar/ChartLinePanel.cxx b/chart2/source/controller/sidebar/ChartLinePanel.cxx
index 019b022bd1a3..9a54f913dca9 100644
--- a/chart2/source/controller/sidebar/ChartLinePanel.cxx
+++ b/chart2/source/controller/sidebar/ChartLinePanel.cxx
@@ -193,7 +193,7 @@ void ChartLinePanel::updateData()
     XLineTransparenceItem aLineTransparenceItem(nLineTransparence);
     updateLineTransparence(false, true, &aLineTransparenceItem);
 
-    sal_uInt32 nWidth;
+    sal_uInt32 nWidth = 0;
     xPropSet->getPropertyValue("LineWidth") >>= nWidth;
     XLineWidthItem aWidthItem(nWidth);
     updateLineWidth(false, true, &aWidthItem);


More information about the Libreoffice-commits mailing list