[Libreoffice-commits] core.git: embedserv/source

Stephan Bergmann (via logerrit) logerrit at kemper.freedesktop.org
Tue Jan 12 20:09:22 UTC 2021


 embedserv/source/embed/docholder.cxx |    7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

New commits:
commit 1b131be9e5a5a5e172bfcd3e1fa577d7ddb3033a
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Tue Jan 12 15:20:43 2021 +0100
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Tue Jan 12 21:08:39 2021 +0100

    Simplify some string construction
    
    (motivated by clang-cl loplugin:stringliteralvar)
    
    Change-Id: Iab08e6128a52710fd7d41f0731ac044c00e7d454
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109173
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/embedserv/source/embed/docholder.cxx b/embedserv/source/embed/docholder.cxx
index ecaeede416b7..762352579d94 100644
--- a/embedserv/source/embed/docholder.cxx
+++ b/embedserv/source/embed/docholder.cxx
@@ -953,12 +953,7 @@ void DocumentHolder::setTitle(const OUString& aDocumentName)
             }
         }
         // set the title
-        static const sal_Unicode u[] = { ' ','(',0 };
-        static const sal_Unicode c[] = { ')',0 };
-        OUString aTotalName(m_aFilterName);
-        aTotalName += OUString(u);
-        aTotalName += aDocumentName;
-        aTotalName += OUString(c);
+        OUString aTotalName(m_aFilterName + " (" + aDocumentName + ")");
         try {
             m_xFrame->setTitle( aTotalName );
         }


More information about the Libreoffice-commits mailing list