[Libreoffice-commits] core.git: cui/uiconfig

[Gabor Kelemen (via logerrit)]

 cui/uiconfig/ui/accelconfigpage.ui |   23 ++++++++++++++++-------
 1 file changed, 16 insertions(+), 7 deletions(-)

New commits:
commit 505b514fe04e35de5640705920fb8cfbcbf7558e
Author:     Gabor Kelemen <kelemen.gabor2 at nisz.hu>
AuthorDate: Mon Jan 11 23:08:49 2021 +0100
Commit:     Olivier Hallot <olivier.hallot at libreoffice.org>
CommitDate: Wed Jan 13 13:06:22 2021 +0100

    tdf#92700 Add extended help tip about searching for combination
    
    by pressing the searched combo.
    
    Also add new tips for widgets that were missing one while at it.
    
    Change-Id: I6c4c1900557d231625061fd0555ce1f990e11aff
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108882
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot at libreoffice.org>

diff --git a/cui/uiconfig/ui/accelconfigpage.ui b/cui/uiconfig/ui/accelconfigpage.ui
index bfc2d0544fb1..47ccb2a97b59 100644
--- a/cui/uiconfig/ui/accelconfigpage.ui
+++ b/cui/uiconfig/ui/accelconfigpage.ui
@@ -42,7 +42,6 @@
       <column type="gchararray"/>
     </columns>
   </object>
-  <!-- n-columns=1 n-rows=1 -->
   <object class="GtkGrid" id="AccelConfigPage">
     <property name="visible">True</property>
     <property name="can_focus">False</property>
@@ -51,7 +50,6 @@
     <property name="border_width">6</property>
     <property name="row_spacing">12</property>
     <child>
-      <!-- n-columns=1 n-rows=1 -->
       <object class="GtkGrid" id="grid3">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
@@ -70,15 +68,16 @@
               <object class="GtkScrolledWindow">
                 <property name="visible">True</property>
                 <property name="can_focus">True</property>
+                <property name="margin_top">6</property>
                 <property name="hexpand">True</property>
                 <property name="vexpand">True</property>
                 <property name="shadow_type">in</property>
-                <property name="margin-top">6</property>
                 <child>
                   <object class="GtkTreeView" id="shortcuts">
                     <property name="visible">True</property>
                     <property name="can_focus">True</property>
                     <property name="receives_default">True</property>
+                    <property name="tooltip_text" translatable="yes" context="accelconfigpage|tooltip|shortcuts">To quickly find a shortcut in this list, simply press the key combination.</property>
                     <property name="hexpand">True</property>
                     <property name="vexpand">True</property>
                     <property name="model">liststore3</property>
@@ -115,7 +114,8 @@
                     </child>
                     <child internal-child="accessible">
                       <object class="AtkObject" id="shortcuts-atkobject">
-                        <property name="AtkObject::accessible-description" translatable="yes" context="accelconfigpage|extended_tip|shortcuts">Lists the shortcut keys and the associated commands. To assign or modify the shortcut key for the command selected in the Function list, click a shortcut in this list, and then click Modify.</property>
+                        <property name="AtkObject::accessible-description" translatable="yes" context="accelconfigpage|extended_tip|shortcuts">Lists the shortcut keys and the associated commands. To assign or modify the shortcut key for the command selected in the Function list, click a shortcut in this list, and then click Modify.
+To quickly find a shortcut in this list, simply press the key combination.</property>
                       </object>
                     </child>
                   </object>
@@ -339,16 +339,21 @@
           <object class="GtkBox">
             <property name="visible">True</property>
             <property name="can_focus">False</property>
-            <property name="orientation">vertical</property>
-            <property name="margin-top">6</property>
+            <property name="margin_top">6</property>
             <property name="hexpand">True</property>
             <property name="vexpand">True</property>
+            <property name="orientation">vertical</property>
             <child>
               <object class="GtkEntry" id="searchEntry">
                 <property name="visible">True</property>
                 <property name="can_focus">True</property>
                 <property name="margin_bottom">5</property>
                 <property name="placeholder_text" translatable="yes" context="accelconfigpage|searchEntry">Type to search</property>
+                <child internal-child="accessible">
+                  <object class="AtkObject" id="searchEntry-atkobject">
+                    <property name="AtkObject::accessible-description" translatable="yes" context="accelconfigpage|extended_tip|searchEntry">Type here to search in the list of functions.</property>
+                  </object>
+                </child>
               </object>
               <packing>
                 <property name="expand">False</property>
@@ -357,7 +362,6 @@
               </packing>
             </child>
             <child>
-              <!-- n-columns=1 n-rows=1 -->
               <object class="GtkGrid" id="grid1">
                 <property name="visible">True</property>
                 <property name="can_focus">False</property>
@@ -532,6 +536,11 @@
                             </child>
                           </object>
                         </child>
+                        <child internal-child="accessible">
+                          <object class="AtkObject" id="keys-atkobject">
+                            <property name="AtkObject::accessible-description" translatable="yes" context="accelconfigpage|extended_tip|keys">Displays the shortcut keys that are assigned to the selected function.</property>
+                          </object>
+                        </child>
                       </object>
                     </child>
                   </object>