[Libreoffice-commits] core.git: registry/source

[Caolán McNamara (via logerrit)]

 registry/source/keyimpl.cxx |    8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

New commits:
commit 729a07528cab3105d23276176ba17fca7fc2231c
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Fri Jan 15 09:56:52 2021 +0000
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Fri Jan 15 14:36:26 2021 +0100

    cid#1471675 silence Logically dead code
    
    Change-Id: I473ee1a4cf3ac6d90acf6872015a7ffa09239e48
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109328
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/registry/source/keyimpl.cxx b/registry/source/keyimpl.cxx
index 00b227efe986..087e5855e6e1 100644
--- a/registry/source/keyimpl.cxx
+++ b/registry/source/keyimpl.cxx
@@ -581,9 +581,6 @@ RegError ORegKey::getValue(std::u16string_view valueName, RegValue value) const
 
     switch (valueType)
     {
-        case RegValueType::NOT_DEFINED:
-            memcpy(value, pBuffer.get(), valueSize);
-            break;
         case RegValueType::LONG:
             readINT32(pBuffer.get(), *static_cast<sal_Int32*>(value));
             break;
@@ -596,10 +593,7 @@ RegError ORegKey::getValue(std::u16string_view valueName, RegValue value) const
         case RegValueType::BINARY:
             memcpy(value, pBuffer.get(), valueSize);
             break;
-        // coverity[dead_error_begin] - following conditions exist to avoid compiler warning
-        case RegValueType::LONGLIST:
-        case RegValueType::STRINGLIST:
-        case RegValueType::UNICODELIST:
+        default:
             memcpy(value, pBuffer.get(), valueSize);
             break;
     }