[Libreoffice-commits] core.git: sw/qa

[Xisco Fauli (via logerrit)]

 sw/qa/uitest/options/optionsDialog.py |    6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

New commits:
commit f7c8fa9591f434c28dfe9c1fc114c4763c2217ca
Author:     Xisco Fauli <xiscofauli at libreoffice.org>
AuthorDate: Fri Jan 15 10:12:31 2021 +0100
Commit:     Xisco Fauli <xiscofauli at libreoffice.org>
CommitDate: Sat Jan 16 08:17:04 2021 +0100

    uitest: simplify code
    
    Change-Id: I1f5d0398de29de339369777e3c9bccd33141464c
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109323
    Tested-by: Jenkins
    Reviewed-by: Xisco Fauli <xiscofauli at libreoffice.org>

diff --git a/sw/qa/uitest/options/optionsDialog.py b/sw/qa/uitest/options/optionsDialog.py
index cf1229e1f315..45cb2a62954a 100644
--- a/sw/qa/uitest/options/optionsDialog.py
+++ b/sw/qa/uitest/options/optionsDialog.py
@@ -5,9 +5,6 @@
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 #
 from uitest.framework import UITestCase
-import time
-import uitest.config
-import uitest.uihelper.common
 
 class optionsDialog(UITestCase):
 
@@ -28,8 +25,7 @@ class optionsDialog(UITestCase):
         def handle_more_icons_dlg(dialog):
             # Check it doesn't crash while opening it
             xCloseBtn = dialog.getChild("buttonClose")
-            while uitest.uihelper.common.get_state_as_dict(xCloseBtn)['Enabled'] != 'true':
-                time.sleep(uitest.config.DEFAULT_SLEEP)
+            self.ui_test.wait_until_property_is_updated(xCloseBtn, "Enabled", "true")
             self.ui_test.close_dialog_through_button(xCloseBtn)
 
         self.ui_test.execute_blocking_action(xMoreIconsBtn.executeAction, args=('CLICK', ()),