[Libreoffice-commits] core.git: sfx2/source

Julien Nabet (via logerrit) logerrit at kemper.freedesktop.org
Sun Jan 17 17:13:45 UTC 2021


 sfx2/source/view/classificationhelper.cxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 5bd90f7f5852056342f1a81a1285b474d468eadd
Author:     Julien Nabet <serval2412 at yahoo.fr>
AuthorDate: Sun Jan 17 15:38:27 2021 +0100
Commit:     Julien Nabet <serval2412 at yahoo.fr>
CommitDate: Sun Jan 17 18:13:03 2021 +0100

    cppcheck: derefInvalidIteratorRedundantCheck (sfx2/classificationhelper)
    
    Change-Id: I25fc7eac5b323e5918f03d8bfb410ca6a860219d
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109476
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
    Reviewed-by: Julien Nabet <serval2412 at yahoo.fr>
    Tested-by: Jenkins

diff --git a/sfx2/source/view/classificationhelper.cxx b/sfx2/source/view/classificationhelper.cxx
index 523fe75571bb..85e7f3d55dde 100644
--- a/sfx2/source/view/classificationhelper.cxx
+++ b/sfx2/source/view/classificationhelper.cxx
@@ -700,14 +700,14 @@ InfobarType SfxClassificationHelper::GetImpactLevelType()
 
     SfxClassificationCategory& rCategory = itCategory->second;
     auto it = rCategory.m_aLabels.find(PROP_PREFIX_INTELLECTUALPROPERTY() + PROP_IMPACTSCALE());
-    OUString aScale = it->second;
     if (it == rCategory.m_aLabels.end())
         return aRet;
+    OUString aScale = it->second;
 
     it = rCategory.m_aLabels.find(PROP_PREFIX_INTELLECTUALPROPERTY() + PROP_IMPACTLEVEL());
-    OUString aLevel = it->second;
     if (it == rCategory.m_aLabels.end())
         return aRet;
+    OUString aLevel = it->second;
 
     // The spec defines two valid scale values: FIPS-199 and UK-Cabinet.
     if (aScale == "UK-Cabinet")


More information about the Libreoffice-commits mailing list