[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - vcl/jsdialog

Henry Castro (via logerrit) logerrit at kemper.freedesktop.org
Tue Jan 19 02:05:40 UTC 2021


 vcl/jsdialog/executor.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit fd23ba7af9031658e2ce1628d9716e5f6e4934d1
Author:     Henry Castro <hcastro at collabora.com>
AuthorDate: Fri Dec 18 08:05:12 2020 -0400
Commit:     Henry Castro <hcastro at collabora.com>
CommitDate: Tue Jan 19 03:05:07 2021 +0100

    jsdialog: disable row activated on "select" action
    
    Unfortunately, when the "Macro Selector Dialog" is shown
    and issue the "select" action, it closes the dialog
    because the row activated trigger double click the macro
    selected.
    
    for moment comment the unexpected side effect
    
    Change-Id: Ibdfa09c444ee79376a9e2251e919f5f06dba577d
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107964
    Tested-by: Jenkins
    Reviewed-by: Henry Castro <hcastro at collabora.com>
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109144
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>

diff --git a/vcl/jsdialog/executor.cxx b/vcl/jsdialog/executor.cxx
index f4bcc817a461..63a8f9dd011f 100644
--- a/vcl/jsdialog/executor.cxx
+++ b/vcl/jsdialog/executor.cxx
@@ -235,7 +235,7 @@ bool ExecuteAction(sal_uInt64 nWindowId, const OString& rWidget, StringMap& rDat
                     pTreeView->select(nRow);
                     pTreeView->set_cursor(nRow);
                     LOKTrigger::trigger_changed(*pTreeView);
-                    LOKTrigger::trigger_row_activated(*pTreeView);
+                    //LOKTrigger::trigger_row_activated(*pTreeView);
                     return true;
                 }
                 else if (sAction == "expand")


More information about the Libreoffice-commits mailing list