[Libreoffice-commits] core.git: vcl/osx
Stephan Bergmann (via logerrit)
logerrit at kemper.freedesktop.org
Tue Jan 19 13:33:52 UTC 2021
vcl/osx/a11ytextattributeswrapper.mm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 064ce013a161e1aa02241a3a65191ae96136ec1b
Author: Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Tue Jan 19 09:58:01 2021 +0100
Commit: Stephan Bergmann <sbergman at redhat.com>
CommitDate: Tue Jan 19 14:33:10 2021 +0100
loplugin:colorcheck (macOS)
as suggested by noelgrandin on IRC, "just add ColorTransparency as the first
param, since that will maintain whatever the code is doing currently (whether it
is actually correct is a different story)"
Change-Id: I3fd7f10ffadc343f3f9a532120e2a7bbb33244d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109616
Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
Reviewed-by: Stephan Bergmann <sbergman at redhat.com>
Tested-by: Jenkins
diff --git a/vcl/osx/a11ytextattributeswrapper.mm b/vcl/osx/a11ytextattributeswrapper.mm
index ac4cb7d2444d..a1a6d0350e4b 100644
--- a/vcl/osx/a11ytextattributeswrapper.mm
+++ b/vcl/osx/a11ytextattributeswrapper.mm
@@ -232,9 +232,9 @@ using namespace ::com::sun::star::uno;
} else if ( property.Name == "CharUnderlineHasColor" ) {
underlineHasColor = [ AquaA11yTextAttributesWrapper convertBoolean: property ];
} else if ( property.Name == "CharColor" ) {
- [ AquaA11yTextAttributesWrapper addColor: property.Value.get<sal_Int32>() forAttribute: NSAccessibilityForegroundColorTextAttribute andRange: range toString: string ];
+ [ AquaA11yTextAttributesWrapper addColor: Color(ColorTransparency, property.Value.get<sal_Int32>()) forAttribute: NSAccessibilityForegroundColorTextAttribute andRange: range toString: string ];
} else if ( property.Name == "CharBackColor" ) {
- [ AquaA11yTextAttributesWrapper addColor: property.Value.get<sal_Int32>() forAttribute: NSAccessibilityBackgroundColorTextAttribute andRange: range toString: string ];
+ [ AquaA11yTextAttributesWrapper addColor: Color(ColorTransparency, property.Value.get<sal_Int32>()) forAttribute: NSAccessibilityBackgroundColorTextAttribute andRange: range toString: string ];
} else if ( property.Name == "CharEscapement" ) {
// values < zero mean subscript
// values > zero mean superscript
@@ -267,7 +267,7 @@ SAL_WNODEPRECATED_DECLARATIONS_POP
}
// add underline information
if ( underlineHasColor ) {
- [ AquaA11yTextAttributesWrapper addColor: underlineColor forAttribute: NSAccessibilityUnderlineColorTextAttribute andRange: range toString: string ];
+ [ AquaA11yTextAttributesWrapper addColor: Color(ColorTransparency, underlineColor) forAttribute: NSAccessibilityUnderlineColorTextAttribute andRange: range toString: string ];
}
// add font information
NSFont * font = [fontDescriptor font];
More information about the Libreoffice-commits
mailing list