[Libreoffice-commits] core.git: vcl/source

[Caolán McNamara (via logerrit)]

 vcl/source/treelist/svimpbox.cxx |    2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 18c5fc0a115b483aca021d7f58dca6096659773b
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Sat Jan 23 20:57:57 2021 +0000
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Sun Jan 24 20:11:18 2021 +0100

    cid#984146 return of Uninitialized pointer field
    
    since...
    
    commit 3d2a431da1126f4924f6cd7e5abac6488cd480e7
    Date:   Thu Jan 7 19:07:23 2021 +0100
    
        tdf#139115 vcl tree list: add new toggle behaviors
    
    I have some remaining concern that m_pCursorOld can end up pointing to a
    deleted row
    
    Change-Id: If5cc9e7fbf16fbd64cdbb6c7843d148c051ee68c
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109843
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/vcl/source/treelist/svimpbox.cxx b/vcl/source/treelist/svimpbox.cxx
index d72de8763981..7d9bfbcfefb3 100644
--- a/vcl/source/treelist/svimpbox.cxx
+++ b/vcl/source/treelist/svimpbox.cxx
@@ -83,6 +83,7 @@ SvImpLBox::SvImpLBox( SvTreeListBox* pLBView, SvTreeList* pLBTree, WinBits nWinS
 
     m_pStartEntry = nullptr;
     m_pCursor             = nullptr;
+    m_pCursorOld          = nullptr;
     m_pAnchor             = nullptr;
     m_nVisibleCount       = 0;    // number of rows of data in control
     m_nNodeBmpTabDistance = NODE_BMP_TABDIST_NOTVALID;
@@ -245,6 +246,7 @@ void SvImpLBox::Clear()
             m_pView->HideFocus();
         m_pCursor = nullptr;
     }
+    m_pCursorOld = nullptr;
     m_aVerSBar->Hide();
     m_aVerSBar->SetThumbPos( 0 );
     Range aRange( 0, 0 );