[Libreoffice-commits] core.git: compilerplugins/clang

[Dr. David Alan Gilbert (via logerrit)]

 compilerplugins/clang/constfieldsrewrite.cxx |    3 ---
 1 file changed, 3 deletions(-)

New commits:
commit 506036ba3f98db5fd83abaf494d3a9ab85561c18
Author:     Dr. David Alan Gilbert <dave at treblig.org>
AuthorDate: Sun Jan 24 17:54:31 2021 +0000
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Mon Jan 25 14:30:36 2021 +0100

    clang/constfieldsrewrite.cxx: Remove duped lines
    
    Spotted by cppcheck.
    A duplicated if and comment; looks like a merge screwup ?
    
    Change-Id: Iceed88d85d42be601975b7a1daff7a1f002644d6
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109863
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/compilerplugins/clang/constfieldsrewrite.cxx b/compilerplugins/clang/constfieldsrewrite.cxx
index 03fb3d0c3609..52da9a153455 100644
--- a/compilerplugins/clang/constfieldsrewrite.cxx
+++ b/compilerplugins/clang/constfieldsrewrite.cxx
@@ -91,9 +91,6 @@ bool ConstFieldsRewrite::VisitFieldDecl(const FieldDecl* fieldDecl)
             fieldDecl->getCanonicalDecl()->getLocation())))
         return true;
     // in case we've already processed this field
-    if (fieldDecl->getType().isConstQualified())
-        return true;
-    // in case we've already processed this field
     if (fieldDecl->getType().isConstQualified())
         return true;
     // TODO rewriting T& is a bit trickier