[Libreoffice-commits] core.git: 2 commits - extensions/source translations

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Mon Jan 25 16:31:32 UTC 2021


 extensions/source/propctrlr/standardcontrol.hxx |    4 +++-
 translations                                    |    2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

New commits:
commit 46e525c36e62c7cb365f1a1f34373e726cfb49b7
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Mon Jan 25 14:54:53 2021 +0000
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Mon Jan 25 17:20:55 2021 +0100

    tdf#139486 also listen to the Entry to determine if the SpinButton was changed
    
    the Window::FocusOut handler the browser installs is called before the
    Control::FocusOut handler, built-into vcl::Control, is called and
    the Control::FocusOut handler is the one that calls the (speculative)
    ValueChanged so the browser determines that the SpinButton is unchanged
    at the time of focus out. If we additionally listen to Changed at the
    Entry level we will correctly know that widget is modified in some way
    at the Window::FocusOut time.
    
    Change-Id: I540d917fc7375fa61662aa69397bcbaa04a91f26
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109912
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/extensions/source/propctrlr/standardcontrol.hxx b/extensions/source/propctrlr/standardcontrol.hxx
index ead1f26bfb6e..0ed0fc635093 100644
--- a/extensions/source/propctrlr/standardcontrol.hxx
+++ b/extensions/source/propctrlr/standardcontrol.hxx
@@ -218,7 +218,9 @@ namespace pcr
         virtual void SetModifyHandler() override
         {
             ONumericControl_Base::SetModifyHandler();
-            getTypedControlWindow()->connect_value_changed( LINK( this, CommonBehaviourControlHelper, MetricModifiedHdl ) );
+            weld::MetricSpinButton* pSpinButton = getTypedControlWindow();
+            pSpinButton->connect_value_changed( LINK( this, CommonBehaviourControlHelper, MetricModifiedHdl ) );
+            pSpinButton->get_widget().connect_changed( LINK( this, CommonBehaviourControlHelper, EditModifiedHdl ) );
         }
 
     private:
commit 05eb593379e29d5a1693ed61a7324dab59222a92
Author:     Christian Lohmaier <lohmaier+LibreOffice at googlemail.com>
AuthorDate: Mon Jan 25 17:20:13 2021 +0100
Commit:     Gerrit Code Review <gerrit at gerrit.libreoffice.org>
CommitDate: Mon Jan 25 17:20:13 2021 +0100

    Update git submodules
    
    * Update translations from branch 'master'
      to cbe7554c6a4fddd40da90728699d7ff5d95cab89
      - update translations for master
    
        and force-fix errors using pocheck
    
        Change-Id: Id37c39c29b4b44c9383bb2cf2606eb27a845852c

diff --git a/translations b/translations
index 4668a661bfdc..cbe7554c6a4f 160000
--- a/translations
+++ b/translations
@@ -1 +1 @@
-Subproject commit 4668a661bfdc743bb88bfc5b7fbc83383974d733
+Subproject commit cbe7554c6a4fddd40da90728699d7ff5d95cab89


More information about the Libreoffice-commits mailing list