[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - extensions/source

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Tue Jan 26 09:50:36 UTC 2021


 extensions/source/propctrlr/standardcontrol.hxx |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 5ccf4f22c98553fc6530b38f235e31f168fa7fef
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Mon Jan 25 14:54:53 2021 +0000
Commit:     Michael Stahl <michael.stahl at allotropia.de>
CommitDate: Tue Jan 26 10:50:01 2021 +0100

    tdf#139486 also listen to the Entry to determine if the SpinButton was changed
    
    the Window::FocusOut handler the browser installs is called before the
    Control::FocusOut handler, built-into vcl::Control, is called and
    the Control::FocusOut handler is the one that calls the (speculative)
    ValueChanged so the browser determines that the SpinButton is unchanged
    at the time of focus out. If we additionally listen to Changed at the
    Entry level we will correctly know that widget is modified in some way
    at the Window::FocusOut time.
    
    Change-Id: I540d917fc7375fa61662aa69397bcbaa04a91f26
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109880
    Tested-by: Jenkins
    Reviewed-by: Michael Stahl <michael.stahl at allotropia.de>

diff --git a/extensions/source/propctrlr/standardcontrol.hxx b/extensions/source/propctrlr/standardcontrol.hxx
index ead1f26bfb6e..0ed0fc635093 100644
--- a/extensions/source/propctrlr/standardcontrol.hxx
+++ b/extensions/source/propctrlr/standardcontrol.hxx
@@ -218,7 +218,9 @@ namespace pcr
         virtual void SetModifyHandler() override
         {
             ONumericControl_Base::SetModifyHandler();
-            getTypedControlWindow()->connect_value_changed( LINK( this, CommonBehaviourControlHelper, MetricModifiedHdl ) );
+            weld::MetricSpinButton* pSpinButton = getTypedControlWindow();
+            pSpinButton->connect_value_changed( LINK( this, CommonBehaviourControlHelper, MetricModifiedHdl ) );
+            pSpinButton->get_widget().connect_changed( LINK( this, CommonBehaviourControlHelper, EditModifiedHdl ) );
         }
 
     private:


More information about the Libreoffice-commits mailing list