[Libreoffice-commits] core.git: basic/qa

Xisco Fauli (via logerrit) logerrit at kemper.freedesktop.org
Fri Jul 2 17:37:31 UTC 2021


 basic/qa/basic_coverage/test_string_replace.vb |    4 ++++
 1 file changed, 4 insertions(+)

New commits:
commit 79657c9f5392a9c243d3f3c14fa190b04b6806e9
Author:     Xisco Fauli <xiscofauli at libreoffice.org>
AuthorDate: Fri Jul 2 18:04:48 2021 +0200
Commit:     Xisco Fauli <xiscofauli at libreoffice.org>
CommitDate: Fri Jul 2 19:36:56 2021 +0200

    tdf#143081: basic_macros: Add unittest
    
    Change-Id: I2d9fa23627f40a2398288b1ee7f5bfd4de4a6131
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118326
    Tested-by: Jenkins
    Reviewed-by: Xisco Fauli <xiscofauli at libreoffice.org>

diff --git a/basic/qa/basic_coverage/test_string_replace.vb b/basic/qa/basic_coverage/test_string_replace.vb
index a2a5f541b3ff..ec51740e17a2 100644
--- a/basic/qa/basic_coverage/test_string_replace.vb
+++ b/basic/qa/basic_coverage/test_string_replace.vb
@@ -20,6 +20,10 @@ Sub verify_stringReplace()
     retStr = Replace("a", "abc", "ab")
     TestUtil.AssertEqual(retStr, "a", "different length of search and replace string: " & retStr)
 
+    ' tdf#143081 - Without the fix in place, this test would have crashed here
+    retStr = Replace("""Straße""", """", """)
+    TestUtil.AssertEqual(retStr, ""Straße"""", "replace doesn't crash: " & retStr)
+
     Exit Sub
 errorHandler:
     TestUtil.ReportErrorHandler("verify_stringReplace", Err, Error$, Erl)


More information about the Libreoffice-commits mailing list