[Libreoffice-commits] core.git: vcl/source

[Caolán McNamara (via logerrit)]

 vcl/source/uitest/uiobject.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 17811ca444676767ec72089c9fe8fb4ccd54cfc6
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Thu Jul 8 10:34:44 2021 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Thu Jul 8 14:42:13 2021 +0200

    we check pChild against null in one branch but not another
    
    presumably we don't need to check against null at all
    
    Change-Id: I3fb909c12a541d1a70e9221f98f7b9337f19a5fb
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118609
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/vcl/source/uitest/uiobject.cxx b/vcl/source/uitest/uiobject.cxx
index 3c3d224024f4..14ff3f5d7690 100644
--- a/vcl/source/uitest/uiobject.cxx
+++ b/vcl/source/uitest/uiobject.cxx
@@ -411,7 +411,7 @@ vcl::Window* findChild(vcl::Window* pParent, const OUString& rID, bool bRequireV
     for (size_t i = 0; i < nCount; ++i)
     {
         vcl::Window* pChild = pParent->GetChild(i);
-        if (pChild && pChild->get_id() == rID
+        if (pChild->get_id() == rID
             && (!bRequireVisible || pChild->IsVisible()))
             return pChild;