[Libreoffice-commits] core.git: vcl/unx

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Fri Jul 9 18:58:01 UTC 2021


 vcl/unx/gtk3/gtkinst.cxx |    4 ++++
 1 file changed, 4 insertions(+)

New commits:
commit caae3b77b23c382f58c1b0dd47ce8ed5d4ccad3b
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Fri Jul 9 16:21:37 2021 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Fri Jul 9 20:57:29 2021 +0200

    gtk4: disregard insert-text signal if it happens while the popup is shown
    
    otherwise we lose our selection
    
    Change-Id: I2be572262528e9bcd12fcb0bc35bf9094f91b990
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118694
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index cd3fd1b5bc84..cd61f4e683d2 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -17445,6 +17445,9 @@ private:
 
     void signal_entry_insert_text(GtkEntry* pEntry, const gchar* pNewText, gint nNewTextLength, gint* position)
     {
+        if (m_bPopupActive) // not entered by the user
+            return;
+
         // first filter inserted text
         if (m_aEntryInsertTextHdl.IsSet())
         {
@@ -17459,6 +17462,7 @@ private:
             }
             g_signal_stop_emission_by_name(pEntry, "insert-text");
         }
+
         if (m_bAutoComplete)
         {
             // now check for autocompletes


More information about the Libreoffice-commits mailing list