[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - basic/qa
Xisco Fauli (via logerrit)
logerrit at kemper.freedesktop.org
Tue Jul 13 09:06:24 UTC 2021
basic/qa/basic_coverage/test_string_replace.vb | 4 ++++
1 file changed, 4 insertions(+)
New commits:
commit fadccf7e6e9a46c54de9578dd708623495ba8e80
Author: Xisco Fauli <xiscofauli at libreoffice.org>
AuthorDate: Fri Jul 2 18:04:48 2021 +0200
Commit: Xisco Fauli <xiscofauli at libreoffice.org>
CommitDate: Tue Jul 13 11:05:50 2021 +0200
tdf#143081: basic_macros: Add unittest
Change-Id: I2d9fa23627f40a2398288b1ee7f5bfd4de4a6131
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118326
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli at libreoffice.org>
Signed-off-by: Xisco Fauli <xiscofauli at libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118817
diff --git a/basic/qa/basic_coverage/test_string_replace.vb b/basic/qa/basic_coverage/test_string_replace.vb
index e2e9ce35962b..8404aaf4961e 100644
--- a/basic/qa/basic_coverage/test_string_replace.vb
+++ b/basic/qa/basic_coverage/test_string_replace.vb
@@ -29,6 +29,10 @@ Function verify_stringReplace() As String
retStr = Replace("a", "abc", "ab")
TestLog_ASSERT retStr, "a", "different length of search and replace string: " & retStr
+ ' tdf#143081 - Without the fix in place, this test would have crashed here
+ retStr = Replace("""Straße""", """", """)
+ TestLog_ASSERT retStr, ""Straße"""", "replace doesn't crash: " & retStr
+
result = result & Chr$(10) & "Tests passed: " & passCount & Chr$(10) & "Tests failed: " & failCount & Chr$(10)
verify_stringReplace = result
End Function
More information about the Libreoffice-commits
mailing list