[Libreoffice-commits] core.git: sdext/source

Kevin Suo (via logerrit) logerrit at kemper.freedesktop.org
Wed Jul 14 16:22:54 UTC 2021


 sdext/source/pdfimport/inc/wrapper.hxx |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

New commits:
commit 6a1de4f74e2510029313771d2751b6cd59141acf
Author:     Kevin Suo <suokunlong at 126.com>
AuthorDate: Tue Jul 13 15:13:45 2021 +0800
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Wed Jul 14 18:22:20 2021 +0200

    tdf#78427 sdext.pdfimport: more bold/italic/Oblique fixes
    
    e.g. the PDF in tdf#107812.
    Also added notes to the fontAttributesSuffixes list.
    
    Change-Id: I4a4dcba2d9369c6b09168a18784d2f6e7d08793d
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118832
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/sdext/source/pdfimport/inc/wrapper.hxx b/sdext/source/pdfimport/inc/wrapper.hxx
index 918f976ee817..12476a01aa1c 100644
--- a/sdext/source/pdfimport/inc/wrapper.hxx
+++ b/sdext/source/pdfimport/inc/wrapper.hxx
@@ -54,21 +54,25 @@ namespace pdfi
                                 const OUString&        rFilterOptions );
 
     const OUString fontAttributesSuffixes[] = {
+        // Note: for performance consideration, each one listed here is evaluated once,
+        // and they are checked from the suffix, thus the order matters.
+        // e.g. for "TimesNewRomanPS-BoldItalic", to get "TimesNewRoman", you should
+        //      first have "Italic", and then "Bold", then "-", and then "PS".
         "MT",
         "PS",
         "PSMT",
         "Regular",
         "Bold",
         "Italic",
-        "Bold",
         "Oblique",
+        "Bold", //BoldItalic, BoldObique
         "Light",
         "Reg",
         "VKana",
         "-",
         ",",
         ";",
-        "PS",
+        "PS", // e.g. TimesNewRomanPS-BoldMT
     };
 }
 


More information about the Libreoffice-commits mailing list