[Libreoffice-commits] core.git: svx/source

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Tue Jul 27 18:12:18 UTC 2021


 svx/source/engine3d/view3d.cxx |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

New commits:
commit 32baf8361a48f5238256acc101241d42c245a711
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Tue Jul 27 13:57:58 2021 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Tue Jul 27 20:11:45 2021 +0200

    cid#1489549 Uncaught exception
    
    no need to check if mpPolygons is in use before deleting it
    
    Change-Id: Ie4fdc35ca70fcef6985268dd317e34dde1ccc950
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119559
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/svx/source/engine3d/view3d.cxx b/svx/source/engine3d/view3d.cxx
index decbf61b7b0c..30fbcb64e24c 100644
--- a/svx/source/engine3d/view3d.cxx
+++ b/svx/source/engine3d/view3d.cxx
@@ -133,10 +133,7 @@ Impl3DMirrorConstructOverlay::~Impl3DMirrorConstructOverlay()
     // The OverlayObjects are cleared using the destructor of OverlayObjectList.
     // That destructor calls clear() at the list which removes all objects from the
     // OverlayManager and deletes them.
-    if(!mrView.IsSolidDragging())
-    {
-        delete[] mpPolygons;
-    }
+    delete[] mpPolygons;
 }
 
 void Impl3DMirrorConstructOverlay::SetMirrorAxis(Point aMirrorAxisA, Point aMirrorAxisB)


More information about the Libreoffice-commits mailing list