[Libreoffice-commits] core.git: filter/source sd/qa

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Tue Jul 27 19:59:07 UTC 2021


 filter/source/graphicfilter/icgm/class4.cxx   |    3 +++
 sd/qa/unit/data/cgm/pass/ofz36348-ubsan-1.cgm |binary
 2 files changed, 3 insertions(+)

New commits:
commit 1940ffc5347768fdc4d2bba636b40d451a274f1e
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Tue Jul 27 19:54:06 2021 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Tue Jul 27 21:58:34 2021 +0200

    ofz#36348 Integer-overflow
    
    Change-Id: I7c6020e94c9ec9d002e66d0ad83426c062ebd5c4
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119574
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/filter/source/graphicfilter/icgm/class4.cxx b/filter/source/graphicfilter/icgm/class4.cxx
index 697a466793bc..8f972ed4f1ee 100644
--- a/filter/source/graphicfilter/icgm/class4.cxx
+++ b/filter/source/graphicfilter/icgm/class4.cxx
@@ -397,6 +397,9 @@ void CGM::ImplDoClass4()
                     bUseless = useless(aCenterPoint.X) || useless(aCenterPoint.Y);
                 }
 
+                if (!bUseless)
+                    bUseless = useless(aStartingPoint.X) || useless(aStartingPoint.Y);
+
                 if (!bUseless)
                 {
                     double fStartAngle = ImplGetOrientation( aCenterPoint, aStartingPoint );
diff --git a/sd/qa/unit/data/cgm/pass/ofz36348-ubsan-1.cgm b/sd/qa/unit/data/cgm/pass/ofz36348-ubsan-1.cgm
new file mode 100644
index 000000000000..4b2e9cf0d8b6
Binary files /dev/null and b/sd/qa/unit/data/cgm/pass/ofz36348-ubsan-1.cgm differ


More information about the Libreoffice-commits mailing list