[Libreoffice-commits] core.git: Changes to 'feature/drawinglayercore2'

Tomaž Vajngerl (via logerrit) logerrit at kemper.freedesktop.org
Fri Jul 30 13:55:12 UTC 2021


New branch 'feature/drawinglayercore2' available with the following commits:
commit 4874765bfbf2ffbc86989df8d6d4fc9a4fe0d0ed
Author: Tomaž Vajngerl <tomaz.vajngerl at collabora.co.uk>
Date:   Fri Jul 23 16:31:02 2021 +0900

    drawinglayer: extract Prop. Value conversion from ViewInformation2D
    
    ViewInformation2D doesn't need to know anything about the Sequence
    of PropertyValue that is used for parameters when constructing it
    through UNO API. This can be done outside of ViewInfromation2D and
    it doesn't need to be responsible for that internally inside the
    ViewInformation2D. With this we get ViewInformation2D, which is much
    simpler and isn't prone to YAGNI.
    
    Change-Id: I3836237a1d26e38145b52136c3204931ae7c6b79

commit ab82922fe1a4436ed19932580bbbbc86c5babe3f
Author: Tomaž Vajngerl <tomaz.vajngerl at collabora.co.uk>
Date:   Thu Jul 22 18:06:30 2021 +0900

    drawinglayer: remove extendedInformation from ViewInformation2D
    
    We actually never use extended information when normally using
    the ViewInformation2D. The exception here is when we construct it
    from property values, where the unknown property values are then
    stored into the extended information sequence and then later
    reconstructed when we convert it back to a sequence of property
    values. Just for that case we don't neeed to expose the extended
    information to the outside and create it, as that is then a
    implementation detail for the UNO use case.
    
    I am also not convinced we need it when creating ViewInformation2D
    with the sequence of property values - it certantly not expected
    that we need to preserve the property values at all, but that is
    something that needs to be checked.
    
    Change-Id: I3b8d533cd412aac8b89ca2921738d6487be5cf45

commit 1d8241386a82a2c6387745256a00512a04581358
Author: Tomaž Vajngerl <tomaz.vajngerl at collabora.co.uk>
Date:   Tue Jul 20 21:39:02 2021 +0900

    svx: cleanup some forward decls, unneeded pragma once, whitespace
    
    Change-Id: I26cd723e0ffe907a7aa8cb4f73ba6bfbd6db5fbc

commit 21875ba4e650f3e64f8fbfaa4dde65268c36023f
Author: Tomaž Vajngerl <tomaz.vajngerl at collabora.co.uk>
Date:   Fri Jul 9 18:55:15 2021 +0900

    drawinglayer: make Primitive2DConteiner header only
    
    Change-Id: I4755f97c32bea33a37ebc2b703a3e71a82508117



More information about the Libreoffice-commits mailing list