[Libreoffice-commits] core.git: vcl/qa

Mike Kaganski (via logerrit) logerrit at kemper.freedesktop.org
Wed Jun 2 18:54:57 UTC 2021


 vcl/qa/cppunit/pdfexport/pdfexport.cxx |    3 ---
 1 file changed, 3 deletions(-)

New commits:
commit 4390f2330cb3da79530d544807eca330d89bf0c0
Author:     Mike Kaganski <mike.kaganski at collabora.com>
AuthorDate: Wed Jun 2 16:54:44 2021 +0200
Commit:     Mike Kaganski <mike.kaganski at collabora.com>
CommitDate: Wed Jun 2 20:54:15 2021 +0200

    Re-enable part of testTdf108963 on Windows
    
    This partially reverts a2c665e4dd73007fe7f0eda2de31db8b768f1df9,
    the expectation is that following pdfium updates have fixed the
    problem that caused failures workarounded by that commit.
    
    Change-Id: Ia2633f966f77c1e9e51f2f8595d7ca62bae78dec
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116464
    Reviewed-by: Mike Kaganski <mike.kaganski at collabora.com>
    Tested-by: Mike Kaganski <mike.kaganski at collabora.com>

diff --git a/vcl/qa/cppunit/pdfexport/pdfexport.cxx b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
index 6d1746b4a8b4..bb203602714d 100644
--- a/vcl/qa/cppunit/pdfexport/pdfexport.cxx
+++ b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
@@ -842,8 +842,6 @@ CPPUNIT_TEST_FIXTURE(PdfExportTest, testTdf108963)
     std::unique_ptr<vcl::pdf::PDFiumPage> pPdfPage = pPdfDocument->openPage(/*nIndex=*/0);
     CPPUNIT_ASSERT(pPdfPage);
 
-    // FIXME: strangely this fails on some Win systems after a pdfium update, expected: 793.7; actual: 793
-#if !defined _WIN32
     // Test page size (28x15.75 cm, was 1/100th mm off, tdf#112690)
     // bad: MediaBox[0 0 793.672440944882 446.428346456693]
     // good: MediaBox[0 0 793.700787401575 446.456692913386]
@@ -906,7 +904,6 @@ CPPUNIT_TEST_FIXTURE(PdfExportTest, testTdf108963)
     }
 
     CPPUNIT_ASSERT_EQUAL(1, nYellowPathCount);
-#endif
 }
 
 CPPUNIT_TEST_FIXTURE(PdfExportTest, testTdf118244_radioButtonGroup)


More information about the Libreoffice-commits mailing list