[Libreoffice-commits] core.git: vcl/unx

[Caolán McNamara (via logerrit)]

 vcl/unx/gtk4/convert3to4.cxx |    7 +++++++
 1 file changed, 7 insertions(+)

New commits:
commit 80f37b8fdc9b3bf39abe437b016cdc69f836058a
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Tue Jun 8 17:16:01 2021 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Wed Jun 9 10:14:56 2021 +0200

    gtk4: default that empty button labels are invisible
    
    Change-Id: If64e9592b48ac376933aac1e30ef76b096a3a0ee
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116859
    Tested-by: Caolán McNamara <caolanm at redhat.com>
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/vcl/unx/gtk4/convert3to4.cxx b/vcl/unx/gtk4/convert3to4.cxx
index a5282b0cece7..46f5c831b828 100644
--- a/vcl/unx/gtk4/convert3to4.cxx
+++ b/vcl/unx/gtk4/convert3to4.cxx
@@ -1156,8 +1156,15 @@ ConvertResult Convert3To4(const css::uno::Reference<css::xml::dom::XNode>& xNode
                 xLabelClassName->setValue("GtkLabel");
                 xNewChildObjectNode->setAttributeNode(xLabelClassName);
                 if (xChildPropertyLabel)
+                {
                     xNewChildObjectNode->appendChild(
                         xChildPropertyLabel->getParentNode()->removeChild(xChildPropertyLabel));
+                }
+                else
+                {
+                    auto xNotVisible = CreateProperty(xDoc, "visible", "False");
+                    xNewChildObjectNode->appendChild(xNotVisible);
+                }
                 if (bChildUseUnderline)
                 {
                     auto xUseUnderline = CreateProperty(xDoc, "use-underline", "True");