[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - vcl/jsdialog

[Szymon KÅ‚os (via logerrit)]

 vcl/jsdialog/jsdialogbuilder.cxx |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 1584da76ab1c671ceacdefef438047ff4a71673e
Author:     Szymon Kłos <szymon.klos at collabora.com>
AuthorDate: Wed Jun 9 10:57:41 2021 +0200
Commit:     Szymon Kłos <szymon.klos at collabora.com>
CommitDate: Wed Jun 9 14:03:15 2021 +0200

    jsdialog: don't send update if not changed checkbox state
    
    to avoid infinite updates in find & replace dialog
    
    Change-Id: If9d26cec66f2b4475c89ba394b9597bc23881341
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116886
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Szymon Kłos <szymon.klos at collabora.com>

diff --git a/vcl/jsdialog/jsdialogbuilder.cxx b/vcl/jsdialog/jsdialogbuilder.cxx
index d9129c32fb74..6bc1248660d0 100644
--- a/vcl/jsdialog/jsdialogbuilder.cxx
+++ b/vcl/jsdialog/jsdialogbuilder.cxx
@@ -1158,8 +1158,10 @@ JSCheckButton::JSCheckButton(JSDialogSender* pSender, ::CheckBox* pCheckBox,
 
 void JSCheckButton::set_active(bool active)
 {
+    bool bWasActive = get_active();
     SalInstanceCheckButton::set_active(active);
-    sendUpdate();
+    if (bWasActive != active)
+        sendUpdate();
 }
 
 JSDrawingArea::JSDrawingArea(JSDialogSender* pSender, VclDrawingArea* pDrawingArea,