[Libreoffice-commits] core.git: connectivity/source

Stephan Bergmann (via logerrit) logerrit at kemper.freedesktop.org
Wed Jun 9 13:36:12 UTC 2021


 connectivity/source/drivers/odbc/OStatement.cxx |    7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

New commits:
commit f09cb84b274edd2a27697a7dc803a7ee42946de2
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Tue Jun 8 11:59:57 2021 +0200
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Wed Jun 9 15:35:26 2021 +0200

    -Werror,-Wunused-but-set-variable (Clang 13 trunk)
    
    ...ever since the code's introduction in
    c25ec0608a167bcf1d891043f02273761c351701 "initial import".  Lets assume that the
    accompanying comment, also present since the "initial import", describes what
    was actually intended, and augment it with a "TODO".
    
    Change-Id: If94a3b72533459d02b1155653b5093c32f034e27
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116834
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/connectivity/source/drivers/odbc/OStatement.cxx b/connectivity/source/drivers/odbc/OStatement.cxx
index 3ec5bebce68c..c5d63ef771a8 100644
--- a/connectivity/source/drivers/odbc/OStatement.cxx
+++ b/connectivity/source/drivers/odbc/OStatement.cxx
@@ -319,7 +319,6 @@ sal_Bool SAL_CALL OStatement_Base::execute( const OUString& sql )
     OString aSql(OUStringToOString(sql,getOwnConnection()->getTextEncoding()));
 
     bool hasResultSet = false;
-    SQLWarning aWarning;
 
     // Reset the statement handle and warning
 
@@ -336,12 +335,10 @@ sal_Bool SAL_CALL OStatement_Base::execute( const OUString& sql )
     try {
         THROW_SQL(N3SQLExecDirect(m_aStatementHandle, reinterpret_cast<SDB_ODBC_CHAR *>(const_cast<char *>(aSql.getStr())), aSql.getLength()));
     }
-    catch (const SQLWarning& ex) {
+    catch (const SQLWarning&) {
 
-        // Save pointer to warning and save with ResultSet
+        //TODO: Save pointer to warning and save with ResultSet
         // object once it is created.
-
-        aWarning = ex;
     }
 
     // Now determine if there is a result set associated with


More information about the Libreoffice-commits mailing list