[Libreoffice-commits] core.git: vcl/inc vcl/source

Noel Grandin (via logerrit) logerrit at kemper.freedesktop.org
Thu Jun 10 11:37:10 UTC 2021


 vcl/inc/svimpbox.hxx             |    2 +-
 vcl/source/treelist/svimpbox.cxx |    4 +---
 2 files changed, 2 insertions(+), 4 deletions(-)

New commits:
commit 0098d36c07d8a6cd4ad59bf4f4c7ad69fdaf6dfd
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Thu Jun 10 11:36:39 2021 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Thu Jun 10 13:36:28 2021 +0200

    loplugin:unnecessaryreturn SvImpLBox::SetMostRight
    
    Change-Id: Id556d8c86c1229a51bd600da433d564979c1cd40
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116975
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/vcl/inc/svimpbox.hxx b/vcl/inc/svimpbox.hxx
index 54382ea6e5d7..554c5a8070ae 100644
--- a/vcl/inc/svimpbox.hxx
+++ b/vcl/inc/svimpbox.hxx
@@ -165,7 +165,7 @@ private:
     void                InitScrollBarBox();
     SvLBoxTab*          NextTab( SvLBoxTab const * );
 
-    bool                SetMostRight( SvTreeListEntry* pEntry );
+    void                SetMostRight( SvTreeListEntry* pEntry );
     void                FindMostRight( SvTreeListEntry* pParent );
     void                FindMostRight_Impl( SvTreeListEntry* pParent );
     void                NotifyTabsChanged();
diff --git a/vcl/source/treelist/svimpbox.cxx b/vcl/source/treelist/svimpbox.cxx
index 60b8a5962e42..11a8fb344998 100644
--- a/vcl/source/treelist/svimpbox.cxx
+++ b/vcl/source/treelist/svimpbox.cxx
@@ -2961,7 +2961,7 @@ void SvImpLBox::SetUpdateMode( bool bMode )
     }
 }
 
-bool SvImpLBox::SetMostRight( SvTreeListEntry* pEntry )
+void SvImpLBox::SetMostRight( SvTreeListEntry* pEntry )
 {
     if( m_pView->nTreeFlags & SvTreeFlags::RECALCTABS )
     {
@@ -2997,10 +2997,8 @@ bool SvImpLBox::SetMostRight( SvTreeListEntry* pEntry )
         {
             m_nMostRight = nRight;
             m_pMostRightEntry = pEntry;
-            return true;
         }
     }
-    return false;
 }
 
 void SvImpLBox::FindMostRight()


More information about the Libreoffice-commits mailing list