[Libreoffice-commits] core.git: writerfilter/source

Noel Grandin (via logerrit) logerrit at kemper.freedesktop.org
Thu Jun 10 12:36:22 UTC 2021


 writerfilter/source/dmapper/FontTable.cxx |    4 ++--
 writerfilter/source/dmapper/FontTable.hxx |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit ff44c5f6bc6a3ca71c87cced03b0cb8ca3c889d6
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Thu Jun 10 11:35:41 2021 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Thu Jun 10 14:35:38 2021 +0200

    loplugin:unnecessaryreturn FontTable::addEmbeddedFont
    
    Change-Id: Ib64799f06ee1fbcc43132df6ad44975a0dff347e
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116973
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/writerfilter/source/dmapper/FontTable.cxx b/writerfilter/source/dmapper/FontTable.cxx
index 7973a42938ec..470deff835ad 100644
--- a/writerfilter/source/dmapper/FontTable.cxx
+++ b/writerfilter/source/dmapper/FontTable.cxx
@@ -224,13 +224,13 @@ sal_uInt32 FontTable::size()
     return m_pImpl->aFontEntries.size();
 }
 
-bool FontTable::addEmbeddedFont(const css::uno::Reference<css::io::XInputStream>& stream,
+void FontTable::addEmbeddedFont(const css::uno::Reference<css::io::XInputStream>& stream,
                                 const OUString& fontName, const char* extra,
                                 std::vector<unsigned char> const & key)
 {
     if (!m_pImpl->xEmbeddedFontHelper)
         m_pImpl->xEmbeddedFontHelper.reset(new EmbeddedFontsHelper);
-    return m_pImpl->xEmbeddedFontHelper->addEmbeddedFont(stream, fontName, extra, key);
+    m_pImpl->xEmbeddedFontHelper->addEmbeddedFont(stream, fontName, extra, key);
 }
 
 EmbeddedFontHandler::EmbeddedFontHandler(FontTable& rFontTable, const OUString& _fontName, const char* _style )
diff --git a/writerfilter/source/dmapper/FontTable.hxx b/writerfilter/source/dmapper/FontTable.hxx
index 0a360b2f14ca..ff4d11fba83e 100644
--- a/writerfilter/source/dmapper/FontTable.hxx
+++ b/writerfilter/source/dmapper/FontTable.hxx
@@ -51,7 +51,7 @@ class FontTable : public LoggedProperties, public LoggedTable
     sal_uInt32          size();
     FontEntry::Pointer_t  getFontEntry(sal_uInt32 nIndex);
 
-    bool addEmbeddedFont(const css::uno::Reference<css::io::XInputStream>& stream,
+    void addEmbeddedFont(const css::uno::Reference<css::io::XInputStream>& stream,
                          const OUString& fontName, const char* extra,
                          std::vector<unsigned char> const & key);
 


More information about the Libreoffice-commits mailing list