[Libreoffice-commits] core.git: sw/source

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Tue Jun 22 10:11:42 UTC 2021


 sw/source/core/layout/pagechg.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 054d6598b29171c3719d7144efe77a408fc4e716
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Tue Jun 22 08:58:46 2021 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Tue Jun 22 12:10:53 2021 +0200

    cid#1486261 Dereference before null check
    
    since...
    
    commit 2e6e87decdb87221a7b832958e03195b1d8fc133
    Date:   Mon Jun 21 13:18:00 2021 +0200
    
        replace dynamic_cast<SwLayoutFrame> with cheaper check
    
    Change-Id: I4623e3eca5a82fa37f52697c189310a835fc76e0
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117614
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sw/source/core/layout/pagechg.cxx b/sw/source/core/layout/pagechg.cxx
index 25e03b9b4c8f..fe90db3b713a 100644
--- a/sw/source/core/layout/pagechg.cxx
+++ b/sw/source/core/layout/pagechg.cxx
@@ -2086,7 +2086,7 @@ static void lcl_MoveAllLowers( SwFrame* pFrame, const Point& rOffset )
     lcl_MoveAllLowerObjs( pFrame, rOffset );
 
     // finally, for layout frames we have to call this function recursively:
-    if ( pFrame && pFrame->IsLayoutFrame() )
+    if (pFrame->IsLayoutFrame())
     {
         SwFrame* pLowerFrame = pFrame->GetLower();
         while ( pLowerFrame )


More information about the Libreoffice-commits mailing list