[Libreoffice-commits] core.git: basic/source

Stephan Bergmann (via logerrit) logerrit at kemper.freedesktop.org
Fri Jun 25 11:48:09 UTC 2021


 basic/source/runtime/dllmgr-x64.cxx |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit fc45cc4899444c218637970ad7537fe7d92077a8
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Fri Jun 25 09:57:51 2021 +0200
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Fri Jun 25 13:47:28 2021 +0200

    No need for a std::string_view here
    
    ...where proc.name is of type OString.  (Following up on
    eebd84b337506c8fff151493f9b51bd127dbc89f "loplugin:stringview (clang-cl)".)
    
    Change-Id: I9e465b431f253d316e8dbff26e6768f5544e91f8
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117835
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/basic/source/runtime/dllmgr-x64.cxx b/basic/source/runtime/dllmgr-x64.cxx
index 8fd83b116440..dad4bea8794a 100644
--- a/basic/source/runtime/dllmgr-x64.cxx
+++ b/basic/source/runtime/dllmgr-x64.cxx
@@ -27,7 +27,6 @@
 #include <algorithm>
 #include <cstddef>
 #include <map>
-#include <string_view>
 #include <vector>
 
 #include <basic/sbx.hxx>
@@ -497,7 +496,7 @@ ErrCode call(
     // require similar treatment, too:
     bool special =
         dll.equalsIgnoreAsciiCase("KERNEL32.DLL") &&
-        (proc.name == std::string_view("GetLogicalDriveStringsA"));
+        (proc.name == "GetLogicalDriveStringsA");
     for (sal_uInt32 i = 1; i < (arguments == nullptr ? 0 : arguments->Count()); ++i)
     {
         ErrCode e = marshal(true, arguments->Get(i), special && i == 2, stack, stack.size(),


More information about the Libreoffice-commits mailing list