[Libreoffice-commits] core.git: sd/source
Michael Meeks (via logerrit)
logerrit at kemper.freedesktop.org
Fri Jun 25 14:12:20 UTC 2021
sd/source/filter/pdf/sdpdffilter.cxx | 5 +++++
1 file changed, 5 insertions(+)
New commits:
commit 4c267311ed7bedfd373db2afc12cad9757922ce1
Author: Michael Meeks <michael.meeks at collabora.com>
AuthorDate: Fri Jun 25 10:31:28 2021 +0100
Commit: Michael Meeks <michael.meeks at collabora.com>
CommitDate: Fri Jun 25 16:11:41 2021 +0200
pdf import: handle out of memory / failure to duplicate page.
Avoid some reported segv's from null pages.
Change-Id: Ic336b36fb57dc70fff183cd5aa5f3f3ef4562674
Signed-off-by: Michael Meeks <michael.meeks at collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117855
Tested-by: Jenkins
diff --git a/sd/source/filter/pdf/sdpdffilter.cxx b/sd/source/filter/pdf/sdpdffilter.cxx
index efa0a0bce0b5..9725bcc8b998 100644
--- a/sd/source/filter/pdf/sdpdffilter.cxx
+++ b/sd/source/filter/pdf/sdpdffilter.cxx
@@ -77,12 +77,17 @@ bool SdPdfFilter::Import()
// Create the page and insert the Graphic.
SdPage* pPage = mrDocument.GetSdPage(nPageNumber, PageKind::Standard);
+ if (!pPage) // failed to duplicate page, out of memory?
+ return false;
// Make the page size match the rendered image.
pPage->SetSize(aSizeHMM);
SdrGrafObj* pSdrGrafObj = new SdrGrafObj(pPage->getSdrModelFromSdrPage(), rGraphic,
tools::Rectangle(Point(), aSizeHMM));
+ if (!pSdrGrafObj) // out of memory
+ return false;
+
pSdrGrafObj->SetResizeProtect(true);
pSdrGrafObj->SetMoveProtect(true);
More information about the Libreoffice-commits
mailing list