[Libreoffice-commits] core.git: chart2/source

Andreas Heinisch (via logerrit) logerrit at kemper.freedesktop.org
Sat Jun 26 08:38:51 UTC 2021


 chart2/source/view/charttypes/Splines.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e6442b39836f9856aa7b87d1a840158f0cb7d9c4
Author:     Andreas Heinisch <andreas.heinisch at yahoo.de>
AuthorDate: Wed May 12 10:33:14 2021 +0200
Commit:     Andreas Heinisch <andreas.heinisch at yahoo.de>
CommitDate: Sat Jun 26 10:38:12 2021 +0200

    tdf#110993 - Corrected spline calculation
    
    The algorithm in Numerical Recipies in C, 2nd edition in Section 3.3,
    page 166 states a division rather than a multiplication.
    
    Change-Id: I2530c506bc48726539e3de99016892e50d6bb87e
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115465
    Tested-by: Jenkins
    Reviewed-by: Andreas Heinisch <andreas.heinisch at yahoo.de>

diff --git a/chart2/source/view/charttypes/Splines.cxx b/chart2/source/view/charttypes/Splines.cxx
index 774d5fc1d7ac..338179b2827c 100644
--- a/chart2/source/view/charttypes/Splines.cxx
+++ b/chart2/source/view/charttypes/Splines.cxx
@@ -198,7 +198,7 @@ void lcl_SplineCalculation::Calculate()
             ( m_fYpN - ( m_aPoints[ n ].second - m_aPoints[ n - 1 ].second ) / xDiff );
     }
 
-    m_aSecDerivY[ n ] = ( un - qn * u[ n - 1 ] ) * ( qn * m_aSecDerivY[ n - 1 ] + 1.0 );
+    m_aSecDerivY[ n ] = ( un - qn * u[ n - 1 ] ) / ( qn * m_aSecDerivY[ n - 1 ] + 1.0 );
 
     // note: the algorithm in [1] iterates from n-1 to 0, but as size_type
     // may be (usually is) an unsigned type, we can not write k >= 0, as this


More information about the Libreoffice-commits mailing list