[Libreoffice-commits] core.git: include/vcl

Stephan Bergmann (via logerrit) logerrit at kemper.freedesktop.org
Mon Jun 28 14:31:15 UTC 2021


 include/vcl/vclptr.hxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit db1e25a0f7c4c912bcdb4ad6a98d13928f522529
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Fri Jun 25 13:37:57 2021 +0200
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Mon Jun 28 16:30:42 2021 +0200

    There appears to be no reason for (DBG_UTIL-only) ~VclPtr to be virtual
    
    ...ever since it was introduced with 3ecb9b4bd7dc70664bbb8d7c957ea8dc5015223f
    "tdf#99352: assert on stray VclPtrs past DeInit"
    
    Change-Id: I4b87a6bacb53f74ff612a4193cee42145ea04fdb
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117878
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/include/vcl/vclptr.hxx b/include/vcl/vclptr.hxx
index 0910257c49f5..3775034ff0c6 100644
--- a/include/vcl/vclptr.hxx
+++ b/include/vcl/vclptr.hxx
@@ -101,7 +101,7 @@ public:
     }
 
 #if defined(DBG_UTIL) && !defined(_WIN32)
-    virtual ~VclPtr()
+    ~VclPtr()
     {
         assert(m_rInnerRef.get() == nullptr || vclmain::isAlive());
         // We can be one of the intermediate counts, but if we are the last


More information about the Libreoffice-commits mailing list