[Libreoffice-commits] core.git: sc/qa

[Xisco Fauli (via logerrit)]

 sc/qa/unit/data/xls/tdf72470.xls       |binary
 sc/qa/unit/subsequent_filters-test.cxx |   17 +++++++++++++++++
 2 files changed, 17 insertions(+)

New commits:
commit 6f343f133800fe09d64be0a3d8ba295eeb877045
Author:     Xisco Fauli <xiscofauli at libreoffice.org>
AuthorDate: Tue Mar 2 22:43:27 2021 +0100
Commit:     Xisco Fauli <xiscofauli at libreoffice.org>
CommitDate: Wed Mar 3 11:59:46 2021 +0100

    tdf#72470: sc_subsequent_filters: Add unittest
    
    Change-Id: Ia43626e11c37f06eb3534182187d4255a9336fd8
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111850
    Tested-by: Jenkins
    Reviewed-by: Xisco Fauli <xiscofauli at libreoffice.org>

diff --git a/sc/qa/unit/data/xls/tdf72470.xls b/sc/qa/unit/data/xls/tdf72470.xls
new file mode 100644
index 000000000000..99d0c1f0fd00
Binary files /dev/null and b/sc/qa/unit/data/xls/tdf72470.xls differ
diff --git a/sc/qa/unit/subsequent_filters-test.cxx b/sc/qa/unit/subsequent_filters-test.cxx
index c85f8d2dbdc5..fa969a78c4d0 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -295,6 +295,7 @@ public:
     void testTdf137091();
     void testTdf62268();
     void testTdf137453();
+    void testTdf72470();
     void testTdf35636();
     void testVBAMacroFunctionODS();
     void testAutoheight2Rows();
@@ -487,6 +488,7 @@ public:
     CPPUNIT_TEST(testTdf137091);
     CPPUNIT_TEST(testTdf62268);
     CPPUNIT_TEST(testTdf137453);
+    CPPUNIT_TEST(testTdf72470);
     CPPUNIT_TEST(testTdf35636);
     CPPUNIT_TEST(testVBAMacroFunctionODS);
     CPPUNIT_TEST(testAutoheight2Rows);
@@ -5191,6 +5193,21 @@ void ScFiltersTest::testTdf137453()
     xDocSh->DoClose();
 }
 
+void ScFiltersTest::testTdf72470()
+{
+    // Without the fix in place, this test would have hung
+
+    ScDocShellRef xDocSh = loadDoc(u"tdf72470.", FORMAT_XLS);
+    CPPUNIT_ASSERT_MESSAGE("Failed to open doc", xDocSh.is());
+
+    ScDocument& rDoc = xDocSh->GetDocument();
+
+    CPPUNIT_ASSERT_EQUAL(OUString("name"), rDoc.GetString(ScAddress(0,0,0)));
+    CPPUNIT_ASSERT_EQUAL(OUString(u"أسمي walid"), rDoc.GetString(ScAddress(0,1,0)));
+
+    xDocSh->DoClose();
+}
+
 void ScFiltersTest::testTdf35636()
 {
     ScDocShellRef xDocSh = loadDoc(u"tdf35636.", FORMAT_ODS);