[Libreoffice-commits] core.git: sd/source

[Caolán McNamara (via logerrit)]

 sd/source/ui/sidebar/LayoutMenu.cxx |    1 -
 1 file changed, 1 deletion(-)

New commits:
commit 77285d2d0266e074520c539556e5a2b660d43b11
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Sun Mar 7 15:41:01 2021 +0000
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Tue Mar 9 12:34:16 2021 +0100

    drop sd::LayoutMenu set_id overwrite
    
    this was added with
    
    commit d2b5ab3498a78c6d164a15b3bf2b947553ea2743
    Date:   Sun Oct 20 09:50:48 2019 -0400
    
        sd: sidebar: force to set the id of the LayoutMenu control
    
        Otherwise, the function std::unique_ptr<UIObject>
        WindowUIObject::get_child(const OUString& rID)
        will not find the control with the rID.
    
        Change-Id: Ie571eb351bb0c59654f577cef1961247273d7608
        Reviewed-on: https://gerrit.libreoffice.org/81345
    
    but there doesn't appear to be a current use of 'sd::LayoutMenu'
    in LibreOffice or Online
    
    Change-Id: I07ebd872f0dd203057c96386730acd5f6aa7a168
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112141
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sd/source/ui/sidebar/LayoutMenu.cxx b/sd/source/ui/sidebar/LayoutMenu.cxx
index 1f245ea2c688..29b4350aef18 100644
--- a/sd/source/ui/sidebar/LayoutMenu.cxx
+++ b/sd/source/ui/sidebar/LayoutMenu.cxx
@@ -165,7 +165,6 @@ LayoutMenu::LayoutMenu (
       mxSidebar(rxSidebar),
       mbIsDisposed(false)
 {
-    set_id("sd::LayoutMenu");
     implConstruct( *mrBase.GetDocument()->GetDocSh() );
     SAL_INFO("sd.ui", "created LayoutMenu at " << this);