[Libreoffice-commits] core.git: vcl/qa

Luboš Luňák (via logerrit) logerrit at kemper.freedesktop.org
Wed Mar 10 11:18:21 UTC 2021


 vcl/qa/cppunit/skia/skia.cxx |    4 ++++
 1 file changed, 4 insertions(+)

New commits:
commit 734f37aaf6027ef2d989b6440370dee46bac0df7
Author:     Luboš Luňák <l.lunak at collabora.com>
AuthorDate: Wed Mar 10 10:28:15 2021 +0100
Commit:     Luboš Luňák <l.lunak at collabora.com>
CommitDate: Wed Mar 10 12:17:33 2021 +0100

    disable SkiaTest::testMatrixQuality because of tb68
    
    Change-Id: I9209ffb54f0a74452e287a7733384e3080aacda4
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112259
    Tested-by: Jenkins
    Reviewed-by: Luboš Luňák <l.lunak at collabora.com>

diff --git a/vcl/qa/cppunit/skia/skia.cxx b/vcl/qa/cppunit/skia/skia.cxx
index 6b18967f0590..3160920405f9 100644
--- a/vcl/qa/cppunit/skia/skia.cxx
+++ b/vcl/qa/cppunit/skia/skia.cxx
@@ -312,6 +312,9 @@ void SkiaTest::testBitmapCopyOnWrite()
 
 void SkiaTest::testMatrixQuality()
 {
+// This test fails on the tb68 tinderbox for a mysterious reason:
+// https://lists.freedesktop.org/archives/libreoffice/2021-March/086969.html
+#if !(defined(_WIN32) && !defined(_WIN64))
     if (!SkiaHelper::isVCLSkiaEnabled())
         return;
     // Not changing the size (but possibly rotated/flipped) does not need high quality transformations.
@@ -323,6 +326,7 @@ void SkiaTest::testMatrixQuality()
     CPPUNIT_ASSERT(SkiaTests::matrixNeedsHighQuality(SkMatrix::Scale(0, -1)));
     CPPUNIT_ASSERT(SkiaTests::matrixNeedsHighQuality(SkMatrix::Scale(2, 1)));
     CPPUNIT_ASSERT(SkiaTests::matrixNeedsHighQuality(SkMatrix::RotateDeg(89)));
+#endif
 }
 
 void SkiaTest::testTdf137329()


More information about the Libreoffice-commits mailing list