[Libreoffice-commits] core.git: sfx2/source

Michael Meeks (via logerrit) logerrit at kemper.freedesktop.org
Thu Mar 11 16:06:54 UTC 2021


 sfx2/source/view/lokhelper.cxx |    3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 40c58f6039fb02cff74e442f6adc5ba38adcff1d
Author:     Michael Meeks <michael.meeks at collabora.com>
AuthorDate: Sun Jan 24 04:10:41 2021 +0000
Commit:     Michael Meeks <michael.meeks at collabora.com>
CommitDate: Thu Mar 11 17:06:14 2021 +0100

    lok: avoid a set of invalidations per view on re-size.
    
    Unfortunate to have N^2 invalidations in the number of views on
    resize - particularly for calc, when you re-size/wrap-text on a
    row during editing.
    
    Change-Id: I93f75c4543ad072684e5575a2cbe0e8abcab0d80
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109913
    Reviewed-by: Jan Holesovsky <kendy at collabora.com>
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112094
    Tested-by: Jenkins
    Reviewed-by: Michael Meeks <michael.meeks at collabora.com>

diff --git a/sfx2/source/view/lokhelper.cxx b/sfx2/source/view/lokhelper.cxx
index 2a5ea882d92d..0da6b9b88682 100644
--- a/sfx2/source/view/lokhelper.cxx
+++ b/sfx2/source/view/lokhelper.cxx
@@ -539,7 +539,10 @@ void SfxLokHelper::notifyDocumentSizeChangedAllViews(vcl::ITiledRenderable* pDoc
         // Should we then do this for all views of all open documents
         // or not?
         if (pCurrentViewShell == nullptr || pViewShell->GetDocId() == pCurrentViewShell-> GetDocId())
+        {
             SfxLokHelper::notifyDocumentSizeChanged(pViewShell, "", pDoc, bInvalidateAll);
+            bInvalidateAll = false; // we direct invalidations to all views anyway.
+        }
         pViewShell = SfxViewShell::GetNext(*pViewShell);
     }
 }


More information about the Libreoffice-commits mailing list