[Libreoffice-commits] core.git: xmlsecurity/source

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Fri Mar 12 09:10:10 UTC 2021


 xmlsecurity/source/helper/xmlsignaturehelper.cxx |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit b344ecfa6d9b9296b1f765490d4ad3e487c33cd4
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Thu Mar 11 20:22:25 2021 +0000
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Fri Mar 12 10:09:21 2021 +0100

    do same logging as ReadAndVerifySignature does
    
    Change-Id: I89c0e29f595049096afa73ff86badc06c0b40d7f
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112365
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/xmlsecurity/source/helper/xmlsignaturehelper.cxx b/xmlsecurity/source/helper/xmlsignaturehelper.cxx
index 94a128b05d75..d91a02ad8124 100644
--- a/xmlsecurity/source/helper/xmlsignaturehelper.cxx
+++ b/xmlsecurity/source/helper/xmlsignaturehelper.cxx
@@ -270,13 +270,14 @@ bool XMLSignatureHelper::ReadAndVerifySignature( const css::uno::Reference< css:
     // Parser -> SignatureReader
     xParser->setDocumentHandler( xHandler );
 
-    // parser the stream
+    // Parse the stream.
     try
     {
         xParser->parseStream( aParserInput );
     }
     catch( uno::Exception& )
     {
+        DBG_UNHANDLED_EXCEPTION("xmlsecurity.helper");
         mbError = true;
     }
 
@@ -407,6 +408,7 @@ bool XMLSignatureHelper::ReadAndVerifySignatureStorageStream(const css::uno::Ref
         DBG_UNHANDLED_EXCEPTION("xmlsecurity.helper");
     }
 
+    // release the signature reader
     mpXSecController->releaseSignatureReader();
 
     return !mbError;


More information about the Libreoffice-commits mailing list